extensions/browser/app_window/app_window.cc - Issue 2194243002: Suppress JavaScript dialogs when a tab puts itself into fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/app_window/app_window.cc

Issue 2194243002: Suppress JavaScript dialogs when a tab puts itself into fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: switch fullscreen call Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/app_window/app_window.cc

diff --git a/extensions/browser/app_window/app_window.cc b/extensions/browser/app_window/app_window.cc

index 7df3954b504836f2fd675079e95c4e3afa9bf122..dbfcaffdab6a1ddf3e9a358ea771ff18324acf04 100644

--- a/extensions/browser/app_window/app_window.cc

+++ b/extensions/browser/app_window/app_window.cc

@@ -917,7 +917,7 @@ void AppWindow::CloseContents(WebContents* contents) {

native_app_window_->Close();

}

-bool AppWindow::ShouldSuppressDialogs(WebContents* source) {

+bool AppWindow::ShouldSuppressDialogs(WebContents* source, bool before_unload) {

return true;

}

« no previous file with comments | « extensions/browser/app_window/app_window.h ('k') | no next file » | no next file with comments »