chrome/browser/extensions/api/tab_capture/offscreen_tab.h - Issue 2194243002: Suppress JavaScript dialogs when a tab puts itself into fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tab_capture/offscreen_tab.h

Issue 2194243002: Suppress JavaScript dialogs when a tab puts itself into fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: switch fullscreen call Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/background/background_contents.cc ('k') | chrome/browser/extensions/api/tab_capture/offscreen_tab.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tab_capture/offscreen_tab.h

diff --git a/chrome/browser/extensions/api/tab_capture/offscreen_tab.h b/chrome/browser/extensions/api/tab_capture/offscreen_tab.h

index 712c1172bc1ff124dbf2c9e5acd59e53b2180243..5bb688f3d9e201f964b5ee2f655f4cd9c8afa2f3 100644

--- a/chrome/browser/extensions/api/tab_capture/offscreen_tab.h

+++ b/chrome/browser/extensions/api/tab_capture/offscreen_tab.h

@@ -125,7 +125,8 @@ class OffscreenTab : protected content::WebContentsDelegate,

// content::WebContentsDelegate overrides to provide the desired behaviors.

void CloseContents(content::WebContents* source) final;

- bool ShouldSuppressDialogs(content::WebContents* source) final;

+ bool ShouldSuppressDialogs(content::WebContents* source,

+ bool before_unload) final;

bool ShouldFocusLocationBarByDefault(content::WebContents* source) final;

bool ShouldFocusPageAfterCrash() final;

void CanDownload(const GURL& url,

« no previous file with comments | « chrome/browser/background/background_contents.cc ('k') | chrome/browser/extensions/api/tab_capture/offscreen_tab.cc » ('j') | no next file with comments »