chrome/browser/extensions/api/tab_capture/offscreen_tab.cc - Issue 2194243002: Suppress JavaScript dialogs when a tab puts itself into fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tab_capture/offscreen_tab.cc

Issue 2194243002: Suppress JavaScript dialogs when a tab puts itself into fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: switch fullscreen call Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/tab_capture/offscreen_tab.cc

diff --git a/chrome/browser/extensions/api/tab_capture/offscreen_tab.cc b/chrome/browser/extensions/api/tab_capture/offscreen_tab.cc

index ddc31cf18549dfeffde8653079308719039f378f..4ed2638253d031ed73bd7ddf9fb97cbd7827e88c 100644

--- a/chrome/browser/extensions/api/tab_capture/offscreen_tab.cc

+++ b/chrome/browser/extensions/api/tab_capture/offscreen_tab.cc

@@ -130,7 +130,8 @@ void OffscreenTab::CloseContents(WebContents* source) {

// |this| is no longer valid.

}

-bool OffscreenTab::ShouldSuppressDialogs(WebContents* source) {

+bool OffscreenTab::ShouldSuppressDialogs(WebContents* source,

+ bool before_unload) {

DCHECK_EQ(offscreen_tab_web_contents_.get(), source);

// Suppress all because there is no possible direct user interaction with

// dialogs.

« no previous file with comments | « chrome/browser/extensions/api/tab_capture/offscreen_tab.h ('k') | chrome/browser/prerender/prerender_contents.cc » ('j') | no next file with comments »