Include constants in deferred computation.

Include constants in deferred computation.

This ensures that in-code constants are included in the deferred computation.

Currently the set of live constants is not computed in itself, so the constants
used in the computation are not the same - and they are generally larger than needed.

R=het@google.com

Committed: https://github.com/dart-lang/sdk/commit/e6241bc12d1449a57fe569a188ecc1f7d9d5186b

[Johnni Winther, 2016-08-01 12:35:27]

Description was changed from

==========
Include constants in deferred computation.

This ensures that in-code constants are included in the deferred computation.

Currently set of live constants is not computed in itself, so the constants
used in the computation are not the same - and are generally larger than needed.
==========

to

==========
Include constants in deferred computation.

This ensures that in-code constants are included in the deferred computation.

Currently the set of live constants is not computed in itself, so the constants
used in the computation are not the same - and they are generally larger than
needed.
==========

[Johnni Winther, 2016-08-01 12:37:11]

johnniwinther@google.com changed reviewers:
+ het@google.com

[Harry Terkelsen, 2016-08-01 17:42:23]

lgtm

https://codereview.chromium.org/2194173002/diff/1/pkg/compiler/lib/src/serial...
File pkg/compiler/lib/src/serialization/equivalence.dart (right):

https://codereview.chromium.org/2194173002/diff/1/pkg/compiler/lib/src/serial...
pkg/compiler/lib/src/serialization/equivalence.dart:959: return
strategy.testTypes(value1, value2, 'payload', value1.dispatchedType,
payload -> dispatchedType

https://codereview.chromium.org/2194173002/diff/1/tests/compiler/dart2js/seri...
File tests/compiler/dart2js/serialization/test_helper.dart (right):

https://codereview.chromium.org/2194173002/diff/1/tests/compiler/dart2js/seri...
tests/compiler/dart2js/serialization/test_helper.dart:154: 
nit: unnecessary blank lines

[Johnni Winther, 2016-08-08 11:38:33]

https://codereview.chromium.org/2194173002/diff/1/pkg/compiler/lib/src/serial...
File pkg/compiler/lib/src/serialization/equivalence.dart (right):

https://codereview.chromium.org/2194173002/diff/1/pkg/compiler/lib/src/serial...
pkg/compiler/lib/src/serialization/equivalence.dart:959: return
strategy.testTypes(value1, value2, 'payload', value1.dispatchedType,
On 2016/08/01 17:42:23, Harry Terkelsen wrote:
> payload -> dispatchedType

Done.

https://codereview.chromium.org/2194173002/diff/1/tests/compiler/dart2js/seri...
File tests/compiler/dart2js/serialization/test_helper.dart (right):

https://codereview.chromium.org/2194173002/diff/1/tests/compiler/dart2js/seri...
tests/compiler/dart2js/serialization/test_helper.dart:154: 
On 2016/08/01 17:42:23, Harry Terkelsen wrote:
> nit: unnecessary blank lines

Done.

[Johnni Winther, 2016-08-08 12:40:05]

Description was changed from

==========
Include constants in deferred computation.

This ensures that in-code constants are included in the deferred computation.

Currently the set of live constants is not computed in itself, so the constants
used in the computation are not the same - and they are generally larger than
needed.
==========

to

==========
Include constants in deferred computation.

This ensures that in-code constants are included in the deferred computation.

Currently the set of live constants is not computed in itself, so the constants
used in the computation are not the same - and they are generally larger than
needed.

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e6241bc12d1449a57fe569a188ecc1f7d9d5186b
==========

[Johnni Winther, 2016-08-08 12:40:07]

Committed patchset #3 (id:40001) manually as
e6241bc12d1449a57fe569a188ecc1f7d9d5186b (presubmit successful).