Include constants in deferred computation.

pkg/compiler/lib/src/constants/expressions.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.constants.expressions;
 
 import '../common.dart';
 import '../constants/constant_system.dart';
 import '../core_types.dart';
 import '../dart_types.dart';
@@ skipping 115 matching lines @@
   /// Implicit constants are simple literals, like bool, int and string
   /// literals, constant references and compositions of implicit constants.
   /// Explicit constants are constructor constants, and constant map and list
   /// literals.
   bool get isImplicit => true;
 
   /// Returns `true` if this expression is only potentially constant, that is,
   /// if it contains positional or named references, used to define constant
   /// constructors.
   // TODO(johnniwinther): Maybe make this final if we use it outside assertions.
-  bool get isPotential => true;
+  bool get isPotential => false;
 }
 
 /// A synthetic constant used to recover from errors.
 class ErroneousConstantExpression extends ConstantExpression {
   ConstantExpressionKind get kind => ConstantExpressionKind.ERRONEOUS;
 
   accept(ConstantExpressionVisitor visitor, [context]) {
     // Do nothing. This is an error.
   }
 
@@ skipping 41 matching lines @@
   }
 
   @override
   bool _equals(SyntheticConstantExpression other) {
     return value == other.value;
   }
 
   ConstantExpressionKind get kind => ConstantExpressionKind.SYNTHETIC;
 
   @override
-  bool get isPotential => false;
-
-  @override
   bool get isImplicit => false;
 }
 
 /// A boolean, int, double, string, or null constant.
 abstract class PrimitiveConstantExpression extends ConstantExpression {
   /// The primitive value of this contant expression.
   get primitiveValue;
 }
 
 /// Boolean literal constant.
@@ skipping 1052 matching lines @@
   @override
   bool _equals(PositionalArgumentReference other) => index == other.index;
 
   @override
   ConstantValue evaluate(
       Environment environment, ConstantSystem constantSystem) {
     throw new UnsupportedError('PositionalArgumentReference.evaluate');
   }
 
   @override
-  bool get isPotential {
-    return true;
-  }
+  bool get isPotential => true;
 }
 
 /// A reference to a named parameter.
 class NamedArgumentReference extends ConstantExpression {
   final String name;
 
   NamedArgumentReference(this.name);
 
   ConstantExpressionKind get kind {
     return ConstantExpressionKind.NAMED_REFERENCE;
@@ skipping 18 matching lines @@
   @override
   bool _equals(NamedArgumentReference other) => name == other.name;
 
   @override
   ConstantValue evaluate(
       Environment environment, ConstantSystem constantSystem) {
     throw new UnsupportedError('NamedArgumentReference.evaluate');
   }
 
   @override
-  bool get isPotential {
-    return true;
-  }
+  bool get isPotential => true;
 }
 
 abstract class FromEnvironmentConstantExpression extends ConstantExpression {
   final ConstantExpression name;
   final ConstantExpression defaultValue;
 
   FromEnvironmentConstantExpression(this.name, this.defaultValue);
 
   @override
   int _computeHashCode() {
@@ skipping 554 matching lines @@
     visit(exp.name);
     if (exp.defaultValue != null) {
       sb.write(', defaultValue: ');
       visit(exp.defaultValue);
     }
     sb.write(')');
   }
 
   String toString() => sb.toString();
 }