Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 219403004: Make DM play nice with the plan to split CPU and GPU work. (Closed)

Created:
6 years, 8 months ago by mtklein_C
Modified:
6 years, 8 months ago
Reviewers:
hal.canary, borenet, mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Make DM play nice with the plan to split CPU and GPU work. --nocpu skips all CPU-bound work. --nogpu skips all GPU-bound work. /m/s/skia (dm) $ r dm --nogpu ninja: Entering directory `out/Release' [17/17] LINK dm (294 GMs, 620 benches) x 4 configs, 245 tests 0 tasks left 71.46user 12.40system 0:04.52elapsed 1854%CPU (0avgtext+0avgdata 16828656maxresident)k 0inputs+0outputs (0major+3252811minor)pagefaults 0swaps /m/s/skia (dm) $ r dm --nocpu ninja: Entering directory `out/Release' ninja: no work to do. (294 GMs, 620 benches) x 4 configs, 245 tests 926 tasks leftUnsupported vertex-color/texture xfer mode. Unsupported vertex-color/texture xfer mode. 0 tasks left 11.10user 2.38system 0:17.15elapsed 78%CPU (0avgtext+0avgdata 1310896maxresident)k 16inputs+4664outputs (0major+161322minor)pagefaults 0swaps BUG=skia:2074 Committed: http://code.google.com/p/skia/source/detail?r=14001

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M dm/DMTask.cpp View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mtklein
6 years, 8 months ago (2014-03-31 18:29:11 UTC) #1
borenet
LGTM \o/ Maybe should be "BUG=skia:2074" ? https://code.google.com/p/skia/issues/detail?id=2074 is "All tools should have an option ...
6 years, 8 months ago (2014-03-31 18:32:31 UTC) #2
mtklein
On 2014/03/31 18:32:31, borenet wrote: > LGTM \o/ > Maybe should be "BUG=skia:2074" ? > ...
6 years, 8 months ago (2014-03-31 18:33:22 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 8 months ago (2014-03-31 18:34:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/219403004/1
6 years, 8 months ago (2014-03-31 18:34:19 UTC) #5
mtklein
The CQ bit was unchecked by mtklein@google.com
6 years, 8 months ago (2014-03-31 18:40:46 UTC) #6
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 8 months ago (2014-03-31 18:40:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/219403004/1
6 years, 8 months ago (2014-03-31 18:41:22 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 19:59:59 UTC) #9
Message was sent while issue was closed.
Change committed as 14001

Powered by Google App Engine
This is Rietveld 408576698