Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: cc/output/software_renderer.h

Issue 2194013002: cc: Delete the Renderer base class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dcheck-delegating
Patch Set: delete-renderer-base-class: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/output/software_renderer.h
diff --git a/cc/output/software_renderer.h b/cc/output/software_renderer.h
index c7e0f809d43fd3171f34b0f069b3e115ebfb16d4..ff5ea508e92b568274654ec9de52e01a1d2043a3 100644
--- a/cc/output/software_renderer.h
+++ b/cc/output/software_renderer.h
@@ -13,7 +13,6 @@
namespace cc {
class OutputSurface;
-class RendererClient;
class ResourceProvider;
class SoftwareOutputDevice;
@@ -27,17 +26,14 @@ class TileDrawQuad;
class CC_EXPORT SoftwareRenderer : public DirectRenderer {
public:
static std::unique_ptr<SoftwareRenderer> Create(
- RendererClient* client,
+ DirectRendererClient* client,
const RendererSettings* settings,
OutputSurface* output_surface,
ResourceProvider* resource_provider);
~SoftwareRenderer() override;
const RendererCapabilitiesImpl& Capabilities() const override;
- void Finish() override;
void SwapBuffers(CompositorFrameMetadata metadata) override;
- void DiscardBackbuffer() override;
- void EnsureBackbuffer() override;
void SetDisablePictureQuadImageFiltering(bool disable) {
disable_picture_quad_image_filtering_ = disable;
@@ -64,13 +60,11 @@ class CC_EXPORT SoftwareRenderer : public DirectRenderer {
DrawingFrame* frame,
std::unique_ptr<CopyOutputRequest> request) override;
- SoftwareRenderer(RendererClient* client,
+ SoftwareRenderer(DirectRendererClient* client,
const RendererSettings* settings,
OutputSurface* output_surface,
ResourceProvider* resource_provider);
- void DidChangeVisibility() override;
-
private:
void ClearCanvas(SkColor color);
void ClearFramebuffer(DrawingFrame* frame);
@@ -110,7 +104,6 @@ class CC_EXPORT SoftwareRenderer : public DirectRenderer {
RendererCapabilitiesImpl capabilities_;
bool is_scissor_enabled_;
- bool is_backbuffer_discarded_;
gfx::Rect scissor_rect_;
SoftwareOutputDevice* output_device_;

Powered by Google App Engine
This is Rietveld 408576698