Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3201)

Unified Diff: cc/output/software_renderer.cc

Issue 2194013002: cc: Delete the Renderer base class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dcheck-delegating
Patch Set: delete-renderer-base-class: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/output/software_renderer.cc
diff --git a/cc/output/software_renderer.cc b/cc/output/software_renderer.cc
index ddc5e4c1a1a09fa5560ae438361c888737016c51..0662b8a4f618b7a1d9b11f1261492ddc831ab892 100644
--- a/cc/output/software_renderer.cc
+++ b/cc/output/software_renderer.cc
@@ -52,7 +52,7 @@ bool IsScaleAndIntegerTranslate(const SkMatrix& matrix) {
} // anonymous namespace
std::unique_ptr<SoftwareRenderer> SoftwareRenderer::Create(
- RendererClient* client,
+ DirectRendererClient* client,
const RendererSettings* settings,
OutputSurface* output_surface,
ResourceProvider* resource_provider) {
@@ -60,13 +60,12 @@ std::unique_ptr<SoftwareRenderer> SoftwareRenderer::Create(
resource_provider));
}
-SoftwareRenderer::SoftwareRenderer(RendererClient* client,
+SoftwareRenderer::SoftwareRenderer(DirectRendererClient* client,
const RendererSettings* settings,
OutputSurface* output_surface,
ResourceProvider* resource_provider)
: DirectRenderer(client, settings, output_surface, resource_provider),
is_scissor_enabled_(false),
- is_backbuffer_discarded_(false),
output_device_(output_surface->software_device()),
current_canvas_(nullptr) {
if (resource_provider_) {
@@ -132,8 +131,6 @@ void SoftwareRenderer::EnsureScissorTestDisabled() {
SetClipRect(gfx::Rect(size.width(), size.height()));
}
-void SoftwareRenderer::Finish() {}
-
void SoftwareRenderer::BindFramebufferToOutputSurface(DrawingFrame* frame) {
DCHECK(!output_surface_->HasExternalStencilTest());
current_framebuffer_lock_ = nullptr;
@@ -608,33 +605,6 @@ void SoftwareRenderer::CopyCurrentRenderPassToBitmap(
request->SendBitmapResult(std::move(bitmap));
}
-void SoftwareRenderer::DiscardBackbuffer() {
- if (is_backbuffer_discarded_)
- return;
-
- output_surface_->DiscardBackbuffer();
-
- is_backbuffer_discarded_ = true;
-
- // Damage tracker needs a full reset every time framebuffer is discarded.
- client_->SetFullRootLayerDamage();
-}
-
-void SoftwareRenderer::EnsureBackbuffer() {
- if (!is_backbuffer_discarded_)
- return;
-
- output_surface_->EnsureBackbuffer();
- is_backbuffer_discarded_ = false;
-}
-
-void SoftwareRenderer::DidChangeVisibility() {
- if (visible())
- EnsureBackbuffer();
- else
- DiscardBackbuffer();
-}
-
bool SoftwareRenderer::ShouldApplyBackgroundFilters(
const RenderPassDrawQuad* quad) const {
if (quad->background_filters.IsEmpty())

Powered by Google App Engine
This is Rietveld 408576698