Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: cc/output/delegating_renderer.h

Issue 2194013002: cc: Delete the Renderer base class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dcheck-delegating
Patch Set: delete-renderer-base-class: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/output/delegating_renderer.h
diff --git a/cc/output/delegating_renderer.h b/cc/output/delegating_renderer.h
index 9e48349a233539771cdd1c775d167ec19fa9a940..1a2e8e2c6b31eb1d1259e311b387d1d4b0a8275f 100644
--- a/cc/output/delegating_renderer.h
+++ b/cc/output/delegating_renderer.h
@@ -17,39 +17,33 @@ namespace cc {
class OutputSurface;
class ResourceProvider;
-class CC_EXPORT DelegatingRenderer : public Renderer {
+class CC_EXPORT DelegatingRenderer {
public:
- static std::unique_ptr<DelegatingRenderer> Create(
- RendererClient* client,
- const RendererSettings* settings,
- OutputSurface* output_surface,
- ResourceProvider* resource_provider);
- ~DelegatingRenderer() override;
+ DelegatingRenderer(OutputSurface* output_surface,
+ ResourceProvider* resource_provider);
+ ~DelegatingRenderer();
- const RendererCapabilitiesImpl& Capabilities() const override;
+ const RendererCapabilitiesImpl& Capabilities() const { return capabilities_; }
void DrawFrame(RenderPassList* render_passes_in_draw_order,
float device_scale_factor,
const gfx::ColorSpace& device_color_space,
const gfx::Rect& device_viewport_rect,
- const gfx::Rect& device_clip_rect) override;
+ const gfx::Rect& device_clip_rect);
+ void SwapBuffers(CompositorFrameMetadata metadata);
- void Finish() override {}
+ // REMOVE THIS.
enne (OOO) 2016/08/08 21:41:18 Are you going to remove this here?
+ void Finish() {}
- void SwapBuffers(CompositorFrameMetadata metadata) override;
- void ReclaimResources(const ReturnedResourceArray&) override;
+ void ReclaimResources(const ReturnedResourceArray&);
- private:
- DelegatingRenderer(RendererClient* client,
- const RendererSettings* settings,
- OutputSurface* output_surface,
- ResourceProvider* resource_provider);
+ void SetVisible(bool visible);
- void DidChangeVisibility() override;
-
- OutputSurface* output_surface_;
- ResourceProvider* resource_provider_;
+ private:
+ OutputSurface* const output_surface_;
+ ResourceProvider* const resource_provider_;
RendererCapabilitiesImpl capabilities_;
+ bool visible_ = true;
std::unique_ptr<DelegatedFrameData> delegated_frame_data_;
DISALLOW_COPY_AND_ASSIGN(DelegatingRenderer);

Powered by Google App Engine
This is Rietveld 408576698