Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: cc/output/delegating_renderer.cc

Issue 2194013002: cc: Delete the Renderer base class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dcheck-delegating
Patch Set: delete-renderer-base-class: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/output/delegating_renderer.cc
diff --git a/cc/output/delegating_renderer.cc b/cc/output/delegating_renderer.cc
index 9438fb8923f2c78e83cf627cc620ba23a2ca4cef..47e9a7942f67ea09b1b456cf31c90cdd180367a4 100644
--- a/cc/output/delegating_renderer.cc
+++ b/cc/output/delegating_renderer.cc
@@ -20,22 +20,9 @@
namespace cc {
-std::unique_ptr<DelegatingRenderer> DelegatingRenderer::Create(
- RendererClient* client,
- const RendererSettings* settings,
- OutputSurface* output_surface,
- ResourceProvider* resource_provider) {
- return base::WrapUnique(new DelegatingRenderer(
- client, settings, output_surface, resource_provider));
-}
-
-DelegatingRenderer::DelegatingRenderer(RendererClient* client,
- const RendererSettings* settings,
- OutputSurface* output_surface,
+DelegatingRenderer::DelegatingRenderer(OutputSurface* output_surface,
ResourceProvider* resource_provider)
- : Renderer(client, settings),
- output_surface_(output_surface),
- resource_provider_(resource_provider) {
+ : output_surface_(output_surface), resource_provider_(resource_provider) {
DCHECK(resource_provider_);
capabilities_.using_partial_swap = false;
@@ -66,11 +53,7 @@ DelegatingRenderer::DelegatingRenderer(RendererClient* client,
}
}
-DelegatingRenderer::~DelegatingRenderer() {}
-
-const RendererCapabilitiesImpl& DelegatingRenderer::Capabilities() const {
- return capabilities_;
-}
+DelegatingRenderer::~DelegatingRenderer() = default;
void DelegatingRenderer::DrawFrame(RenderPassList* render_passes_in_draw_order,
float device_scale_factor,
@@ -110,9 +93,12 @@ void DelegatingRenderer::ReclaimResources(
resource_provider_->ReceiveReturnsFromParent(resources);
}
-void DelegatingRenderer::DidChangeVisibility() {
+void DelegatingRenderer::SetVisible(bool visible) {
+ if (visible == visible_)
+ return;
+ visible_ = visible;
ContextProvider* context_provider = output_surface_->context_provider();
- if (!visible()) {
+ if (!visible_) {
TRACE_EVENT0("cc", "DelegatingRenderer::SetVisible dropping resources");
if (context_provider) {
context_provider->DeleteCachedResources();
@@ -121,8 +107,7 @@ void DelegatingRenderer::DidChangeVisibility() {
}
if (context_provider) {
// If we are not visible, we ask the context to aggressively free resources.
- context_provider->ContextSupport()->SetAggressivelyFreeResources(
- !visible());
+ context_provider->ContextSupport()->SetAggressivelyFreeResources(!visible_);
}
}

Powered by Google App Engine
This is Rietveld 408576698