Issue 2193983003: Revert of simplify neon shifts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2193983003: Revert of simplify neon shifts (Closed)

Created:
4 years, 4 months ago by mtklein

Modified:
4 years, 4 months ago

Reviewers:
msarett, mtklein_C

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of simplify neon shifts (patchset #2 id:20001 of https://codereview.chromium.org/2194953002/ ) Reason for revert: Reverting so I can revert https://codereview.chromium.org/2196773002 Original issue's description: > simplify neon shifts > > These still generate vshr/vshl with immediates with both GCC and Clang. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2194953002 > CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > Based on https://codereview.chromium.org/2196773002 > > Committed: https://skia.googlesource.com/skia/+/79b59e6a3877068067395ff8bd711c5332eb22a9 TBR=msarett@google.com,mtklein@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia:

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -8 lines)			Patch
	M	src/opts/SkNx_neon.h	View		6 chunks	+34 lines, -8 lines	0 comments	Download

Total messages: 5 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193983003/1

4 years, 4 months ago (2016-07-30 20:35:14 UTC) #3

Looks like I don't need to revert this after all.  Nice.