Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Issue 219393002: Revert 20348 - "Fix LoadFieldByIndex to take mutable heap-numbers into account." (Closed)

Created:
6 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Revert 20348 - "Fix LoadFieldByIndex to take mutable heap-numbers into account." Reason for revert: crashes benchmarks/sunspider/string-fasta on ia32.debug This also reverts r20350 and r20352 > Fix LoadFieldByIndex to take mutable heap-numbers into account. > > BUG= > R=ishell@chromium.org > > Review URL: https://codereview.chromium.org/213213002 BUG=none LOG=n TBR=verwaest@chromium.org Revert "Use sarq on x64" This reverts commit e2a8ef9321345c6bc091054443bf2b9535ff6b1c. Revert "Don't | int and bool" This reverts commit c90d713d3a8ceba4fec41933a63beb6e50a3d7c0. Committed: https://code.google.com/p/v8/source/detail?r=20354

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -270 lines) Patch
M src/arm/lithium-arm.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +0 lines, -49 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 2 chunks +0 lines, -48 lines 0 comments Download
M src/handles.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +0 lines, -46 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +0 lines, -45 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/fuzz-natives-part1.js View 1 chunk +0 lines, -3 lines 0 comments Download
D test/mjsunit/regress/regress-load-field-by-index.js View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-03-31 13:23:06 UTC) #1
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-03-31 13:23:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r20354 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698