Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 213213002: Fix LoadFieldByIndex to take mutable heap-numbers into account. (Closed)

Created:
6 years, 9 months ago by Toon Verwaest
Modified:
6 years, 8 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Fix LoadFieldByIndex to take mutable heap-numbers into account. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20348

Patch Set 1 : #

Patch Set 2 : Platform ports #

Patch Set 3 : Fix arm/arm64 #

Patch Set 4 : Use TestAndBranchIfAnySet on arm64 #

Total comments: 2

Patch Set 5 : Addressed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -14 lines) Patch
M src/arm/lithium-arm.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 3 4 2 chunks +49 lines, -0 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/arm64/lithium-codegen-arm64.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 2 3 2 chunks +48 lines, -0 lines 0 comments Download
M src/handles.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +46 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/objects.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 chunks +45 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M test/mjsunit/fuzz-natives-part1.js View 1 chunk +3 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-load-field-by-index.js View 1 chunk +11 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
6 years, 9 months ago (2014-03-28 11:03:30 UTC) #1
Igor Sheludko
lgtm with a nit: https://codereview.chromium.org/213213002/diff/80001/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): https://codereview.chromium.org/213213002/diff/80001/src/arm/lithium-codegen-arm.cc#newcode5771 src/arm/lithium-codegen-arm.cc:5771: __ cmp(scratch, Operand::Zero()); and + ...
6 years, 8 months ago (2014-03-31 09:50:16 UTC) #2
Toon Verwaest
Addressed nit https://codereview.chromium.org/213213002/diff/80001/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): https://codereview.chromium.org/213213002/diff/80001/src/arm/lithium-codegen-arm.cc#newcode5771 src/arm/lithium-codegen-arm.cc:5771: __ cmp(scratch, Operand::Zero()); On 2014/03/31 09:50:16, Igor ...
6 years, 8 months ago (2014-03-31 09:56:30 UTC) #3
Toon Verwaest
6 years, 8 months ago (2014-03-31 11:59:44 UTC) #4
Message was sent while issue was closed. 
Committed patchset #5 manually as r20348 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698