Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2193843003: [Android] Fix failures not being logged on host_info step. (Closed)

Created:
4 years, 4 months ago by rnephew (Reviews Here)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

[Android] Fix failures not being logged on host_info step. BUG=592140 Committed: https://chromium.googlesource.com/chromium/tools/build/+/7dbd97def26032d65206d7dd19aa7b09d98c5cc6

Patch Set 1 #

Total comments: 4

Patch Set 2 : [Android] Fix failures not being logged on host_info step. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -127 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 1 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Galaxy_S5_Perf__1_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Power_Nexus_5X_Perf__1_.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/get_perf_test_list_old_data.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/host_info_failure.json View 2 chunks +3 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/missing_device.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/src_side_script_fails.json View 2 chunks +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/test_failure.json View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rnephew (Reviews Here)
4 years, 4 months ago (2016-07-29 17:48:37 UTC) #2
jbudorick
lgtm https://codereview.chromium.org/2193843003/diff/1/scripts/slave/recipe_modules/chromium_android/api.py File scripts/slave/recipe_modules/chromium_android/api.py (right): https://codereview.chromium.org/2193843003/diff/1/scripts/slave/recipe_modules/chromium_android/api.py#newcode379 scripts/slave/recipe_modules/chromium_android/api.py:379: 'Host Info', This is really the most important ...
4 years, 4 months ago (2016-07-29 18:17:41 UTC) #3
rnephew (Reviews Here)
https://codereview.chromium.org/2193843003/diff/1/scripts/slave/recipe_modules/chromium_android/api.py File scripts/slave/recipe_modules/chromium_android/api.py (right): https://codereview.chromium.org/2193843003/diff/1/scripts/slave/recipe_modules/chromium_android/api.py#newcode379 scripts/slave/recipe_modules/chromium_android/api.py:379: 'Host Info', On 2016/07/29 18:17:41, jbudorick wrote: > This ...
4 years, 4 months ago (2016-07-29 18:44:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193843003/20001
4 years, 4 months ago (2016-07-29 18:45:03 UTC) #7
ghost stip (do not use)
lgtm
4 years, 4 months ago (2016-07-29 18:47:27 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 18:49:28 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/7dbd97def26032d65206...

Powered by Google App Engine
This is Rietveld 408576698