scripts/slave/recipes/android/perf.expected/host_info_failure.json - Issue 2193843003: [Android] Fix failures not being logged on host_info step.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/android/perf.expected/host_info_failure.json

Issue 2193843003: [Android] Fix failures not being logged on host_info step. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: [Android] Fix failures not being logged on host_info step. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/android/perf.expected/get_perf_test_list_old_data.json ('k') | scripts/slave/recipes/android/perf.expected/missing_device.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/android/perf.expected/host_info_failure.json

diff --git a/scripts/slave/recipes/android/perf.expected/host_info_failure.json b/scripts/slave/recipes/android/perf.expected/host_info_failure.json

index eb1f1748a5b632f363017a5d108194acc7d1ed10..65ca0755d0f1173ef82e9e9d4dc463cd005cdce7 100644

--- a/scripts/slave/recipes/android/perf.expected/host_info_failure.json

+++ b/scripts/slave/recipes/android/perf.expected/host_info_failure.json

@@ -452,7 +452,7 @@

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",

"PATH": "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools:[SLAVE_BUILD]/src/build/android:%(PATH)s"

- "name": "Host_Info",

+ "name": "Host Info",

"~followup_annotations": [

"step returned non-zero exit code: 87",

"@@@STEP_LOG_LINE@json.output@{@@@",

@@ -493,7 +493,8 @@

"@@@STEP_LOG_LINE@json.output@ \"python_version\": \"python_version\"@@@",

"@@@STEP_LOG_LINE@json.output@ }, @@@",

"@@@STEP_LOG_LINE@json.output@ \"failures\": [@@@",

- "@@@STEP_LOG_LINE@json.output@ \"Device 3208154b735c5117 blacklisted\"@@@",

+ "@@@STEP_LOG_LINE@json.output@ \"Failure A\", @@@",

+ "@@@STEP_LOG_LINE@json.output@ \"Failure B\"@@@",

"@@@STEP_LOG_LINE@json.output@ ], @@@",

"@@@STEP_LOG_LINE@json.output@ \"valid\": true@@@",

"@@@STEP_LOG_LINE@json.output@}@@@",