Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2193783003: Notify WindowStateObserver when minimizing in maximized mode. (Closed)

Created:
4 years, 4 months ago by oshima
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Notify WindowStateObserver when minimizing in maximized mode. BUG=631498 TEST=covered by unittest Review-Url: https://codereview.chromium.org/2182183002 Cr-Commit-Position: refs/heads/master@{#408320} (cherry picked from commit 2d49e855263fbcbb63b7e6dd153b3240577348e3) Committed: https://chromium.googlesource.com/chromium/src/+/cd28d911352b50cfc168015094373282cf61b45b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -20 lines) Patch
M ash/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M ash/common/wm/maximize_mode/maximize_mode_window_state.cc View 2 chunks +13 lines, -14 lines 0 comments Download
M ash/common/wm/window_state_observer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc View 3 chunks +102 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
oshima
4 years, 4 months ago (2016-07-29 13:21:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cd28d911352b50cfc168015094373282cf61b45b.

Powered by Google App Engine
This is Rietveld 408576698