Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 2182183002: Notify WindowStateObserver when minimizing in maximized mode. (Closed)

Created:
4 years, 4 months ago by oshima
Modified:
4 years, 4 months ago
CC:
chromium-reviews, kalyank, sadrul, reveman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Notify WindowStateObserver when minimizing in maximized mode. BUG=631498 TEST=covered by unittest Committed: https://crrev.com/2d49e855263fbcbb63b7e6dd153b3240577348e3 Cr-Commit-Position: refs/heads/master@{#408320}

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -20 lines) Patch
M ash/BUILD.gn View 1 1 chunk +2 lines, -1 line 0 comments Download
M ash/common/wm/maximize_mode/maximize_mode_window_state.cc View 2 chunks +13 lines, -14 lines 0 comments Download
M ash/common/wm/window_state_observer.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc View 1 3 chunks +102 lines, -5 lines 0 comments Download

Messages

Total messages: 24 (15 generated)
oshima
4 years, 4 months ago (2016-07-26 16:00:32 UTC) #7
Mr4D (OOO till 08-26)
lgtm
4 years, 4 months ago (2016-07-28 01:36:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182183002/20001
4 years, 4 months ago (2016-07-28 01:55:35 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/103301)
4 years, 4 months ago (2016-07-28 02:03:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182183002/20001
4 years, 4 months ago (2016-07-28 02:09:16 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/103319)
4 years, 4 months ago (2016-07-28 02:19:34 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182183002/20001
4 years, 4 months ago (2016-07-28 02:24:10 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-28 02:54:06 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 02:56:30 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2d49e855263fbcbb63b7e6dd153b3240577348e3
Cr-Commit-Position: refs/heads/master@{#408320}

Powered by Google App Engine
This is Rietveld 408576698