Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 219373005: Simplify ExceptionState::throwException() (Closed)

Created:
6 years, 8 months ago by fs
Modified:
6 years, 8 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

Simplify ExceptionState::throwException() Drop the case in which m_code has been set without also setting m_exception. Followup to https://codereview.chromium.org/219263002/. R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170457

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M Source/bindings/v8/ExceptionState.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
fs
6 years, 8 months ago (2014-03-31 14:52:04 UTC) #1
haraken
LGTM
6 years, 8 months ago (2014-03-31 15:39:49 UTC) #2
fs
The CQ bit was checked by fs@opera.com
6 years, 8 months ago (2014-03-31 15:52:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/219373005/1
6 years, 8 months ago (2014-03-31 15:52:12 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 15:59:52 UTC) #5
Message was sent while issue was closed.
Change committed as 170457

Powered by Google App Engine
This is Rietveld 408576698