Source/bindings/v8/ExceptionState.cpp - Issue 219373005: Simplify ExceptionState::throwException()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ExceptionState.cpp

Issue 219373005: Simplify ExceptionState::throwException() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ExceptionState.cpp

diff --git a/Source/bindings/v8/ExceptionState.cpp b/Source/bindings/v8/ExceptionState.cpp

index 005668015f43232abd39c8f1dc9972b8b063994e..1d95598c623298e3a1156d06502bf2ba0e973d37 100644

--- a/Source/bindings/v8/ExceptionState.cpp

+++ b/Source/bindings/v8/ExceptionState.cpp

@@ -81,9 +81,6 @@ void ExceptionState::setException(v8::Handle<v8::Value> exception)

void ExceptionState::throwException()

{

- ASSERT(!m_exception.isEmpty() || m_code);

- if (m_exception.isEmpty())

- throwDOMException(m_code, String()); // FIXME: Do we ever hit this? If so, where and why?

ASSERT(!m_exception.isEmpty());

V8ThrowException::throwError(m_exception.newLocal(m_isolate), m_isolate);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »