Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: extensions/common/features/complex_feature_unittest.cc

Issue 2193693003: Further reduction of feature_compiler.py generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test-with-leiz
Patch Set: tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/features/complex_feature_unittest.cc
diff --git a/extensions/common/features/complex_feature_unittest.cc b/extensions/common/features/complex_feature_unittest.cc
index bff752dd8549a7fea88840bd04d8c2a6b06b77d0..adf50811d51ce92e5c26757024e8d745efc8dd93 100644
--- a/extensions/common/features/complex_feature_unittest.cc
+++ b/extensions/common/features/complex_feature_unittest.cc
@@ -17,8 +17,7 @@ namespace extensions {
TEST(ComplexFeatureTest, MultipleRulesWhitelist) {
const std::string kIdFoo("fooabbbbccccddddeeeeffffgggghhhh");
const std::string kIdBar("barabbbbccccddddeeeeffffgggghhhh");
- std::unique_ptr<ComplexFeature::FeatureList> features(
- new ComplexFeature::FeatureList());
+ std::vector<Feature*> features;
// Rule: "extension", whitelist "foo".
std::unique_ptr<SimpleFeature> simple_feature(new SimpleFeature);
@@ -28,7 +27,7 @@ TEST(ComplexFeatureTest, MultipleRulesWhitelist) {
.Set("extension_types", ListBuilder().Append("extension").Build())
.Build());
simple_feature->Parse(rule.get());
- features->push_back(std::move(simple_feature));
+ features.push_back(simple_feature.release());
// Rule: "legacy_packaged_app", whitelist "bar".
simple_feature.reset(new SimpleFeature);
@@ -38,10 +37,9 @@ TEST(ComplexFeatureTest, MultipleRulesWhitelist) {
ListBuilder().Append("legacy_packaged_app").Build())
.Build();
simple_feature->Parse(rule.get());
- features->push_back(std::move(simple_feature));
+ features.push_back(simple_feature.release());
- std::unique_ptr<ComplexFeature> feature(
- new ComplexFeature(std::move(features)));
+ std::unique_ptr<ComplexFeature> feature(new ComplexFeature(features));
// Test match 1st rule.
EXPECT_EQ(
@@ -80,8 +78,7 @@ TEST(ComplexFeatureTest, MultipleRulesWhitelist) {
// Tests that dependencies are correctly checked.
TEST(ComplexFeatureTest, Dependencies) {
- std::unique_ptr<ComplexFeature::FeatureList> features(
- new ComplexFeature::FeatureList());
+ std::vector<Feature*> features;
// Rule which depends on an extension-only feature (content_security_policy).
std::unique_ptr<SimpleFeature> simple_feature(new SimpleFeature);
@@ -91,7 +88,7 @@ TEST(ComplexFeatureTest, Dependencies) {
ListBuilder().Append("manifest:content_security_policy").Build())
.Build();
simple_feature->Parse(rule.get());
- features->push_back(std::move(simple_feature));
+ features.push_back(simple_feature.release());
// Rule which depends on an platform-app-only feature (serial).
simple_feature.reset(new SimpleFeature);
@@ -100,7 +97,7 @@ TEST(ComplexFeatureTest, Dependencies) {
ListBuilder().Append("permission:serial").Build())
.Build();
simple_feature->Parse(rule.get());
- features->push_back(std::move(simple_feature));
+ features.push_back(simple_feature.release());
std::unique_ptr<ComplexFeature> feature(
new ComplexFeature(std::move(features)));

Powered by Google App Engine
This is Rietveld 408576698