Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: extensions/common/features/complex_feature.cc

Issue 2193693003: Further reduction of feature_compiler.py generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test-with-leiz
Patch Set: tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/features/complex_feature.cc
diff --git a/extensions/common/features/complex_feature.cc b/extensions/common/features/complex_feature.cc
index 5f041dbbc982786192cf3db7d81f36cc041dcbc5..fa5325c7afcbd62f0782a0a2354cf6ad79c25b13 100644
--- a/extensions/common/features/complex_feature.cc
+++ b/extensions/common/features/complex_feature.cc
@@ -6,9 +6,10 @@
namespace extensions {
-ComplexFeature::ComplexFeature(std::unique_ptr<FeatureList> features) {
- DCHECK_GT(features->size(), 0UL);
- features_.swap(*features);
+ComplexFeature::ComplexFeature(const std::vector<Feature*>& features) {
+ DCHECK_GT(features.size(), 0UL);
+ for (Feature* f : features)
+ features_.push_back(std::unique_ptr<Feature>(f));
no_parent_ = features_[0]->no_parent();
#if !defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)

Powered by Google App Engine
This is Rietveld 408576698