Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: extensions/common/features/base_feature_provider.cc

Issue 2193693003: Further reduction of feature_compiler.py generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test-with-leiz
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/features/base_feature_provider.cc
diff --git a/extensions/common/features/base_feature_provider.cc b/extensions/common/features/base_feature_provider.cc
index adc463cc04e9b6a54542995d055c5aee1ec860b6..26a4e740b9e1c660348ae733bacb3d75006b58eb 100644
--- a/extensions/common/features/base_feature_provider.cc
+++ b/extensions/common/features/base_feature_provider.cc
@@ -66,4 +66,8 @@ void BaseFeatureProvider::AddFeature(base::StringPiece name,
features_[name.as_string()] = std::move(feature);
}
+void BaseFeatureProvider::AddFeature(base::StringPiece name, Feature* feature) {
+ features_[name.as_string()] = std::unique_ptr<Feature>(feature);
Devlin 2016/07/29 20:13:49 For the record, this is what I was talking about w
+}
+
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698