Further reduction of feature_compiler.py generated code

extensions/common/features/base_feature_provider.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/features/base_feature_provider.h"
 
 #include <utility>
 
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
@@ skipping 48 matching lines @@
     result.push_back(it->second.get());
   }
   return result;
 }
 
 void BaseFeatureProvider::AddFeature(base::StringPiece name,
                                      std::unique_ptr<Feature> feature) {
   features_[name.as_string()] = std::move(feature);
 }
 
+void BaseFeatureProvider::AddFeature(base::StringPiece name, Feature* feature) {
+  features_[name.as_string()] = std::unique_ptr<Feature>(feature);

[Devlin, 2016/07/29 20:13:49]

For the record, this is what I was talking about with FeatureProvider - we still
have features_ has an STL container of unique_ptrs, but just pass it in by raw
ptr and then add it to the container as a unique_ptr.  With the complex feature,
we already have the container, so maybe we could avoid the wrap/unwrap just
through the generated code.  See other comment.

+}
+
 }  // namespace extensions