extensions/common/features/complex_feature.h - Issue 2193693003: Further reduction of feature_compiler.py generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/features/complex_feature.h

Issue 2193693003: Further reduction of feature_compiler.py generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test-with-leiz

Patch Set: . Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/features/base_feature_provider.cc ('k') | extensions/common/features/complex_feature.cc » ('j') | extensions/common/features/complex_feature.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/features/complex_feature.h

diff --git a/extensions/common/features/complex_feature.h b/extensions/common/features/complex_feature.h

index 7b63ae6f957b08809537c9ac8891ddc51dc9db66..960a734fa4db4fdd353f6eb020ccb55fdc58f874 100644

--- a/extensions/common/features/complex_feature.h

+++ b/extensions/common/features/complex_feature.h

@@ -23,9 +23,9 @@ namespace extensions {

// available, but not if only some combination of Features is available.

class ComplexFeature : public Feature {

public:

- using FeatureList = std::vector<std::unique_ptr<Feature>>;

+ using FeatureList = std::vector<Feature*>;

- explicit ComplexFeature(std::unique_ptr<FeatureList> features);

+ explicit ComplexFeature(FeatureList* features);

Devlin 2016/07/29 18:50:15 I think there are a few testing call sites that st

~ComplexFeature() override;

// extensions::Feature: