Further reduction of feature_compiler.py generated code

extensions/common/features/complex_feature.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_COMMON_FEATURES_COMPLEX_FEATURE_H_
 #define EXTENSIONS_COMMON_FEATURES_COMPLEX_FEATURE_H_
 
 #include <memory>
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/features/feature.h"
 #include "extensions/common/manifest.h"
 
 namespace extensions {
 
 // A ComplexFeature is composed of one or many Features. A ComplexFeature
 // is available if any Feature (i.e. permission rule) that composes it is
 // available, but not if only some combination of Features is available.
 class ComplexFeature : public Feature {
  public:
-  using FeatureList = std::vector<std::unique_ptr<Feature>>;
+  using FeatureList = std::vector<Feature*>;
 
-  explicit ComplexFeature(std::unique_ptr<FeatureList> features);
+  explicit ComplexFeature(FeatureList* features);

[Devlin, 2016/07/29 18:50:15]

I think there are a few testing call sites that still need to be updated here.

   ~ComplexFeature() override;
 
   // extensions::Feature:
   Availability IsAvailableToManifest(const std::string& extension_id,
                                      Manifest::Type type,
                                      Manifest::Location location,
                                      int manifest_version,
                                      Platform platform) const override;
 
   Availability IsAvailableToContext(const Extension* extension,
@@ skipping 12 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(FeaturesGenerationTest, FeaturesTest);
 
   FeatureList features_;
 
   DISALLOW_COPY_AND_ASSIGN(ComplexFeature);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_COMMON_FEATURES_COMPLEX_FEATURE_H_