Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2193543002: [ios] Added web::test::SetUpHttpServer which takes ResponseProvider. (Closed)

Created:
4 years, 4 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 4 months ago
Reviewers:
baxley
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Added web::test::SetUpHttpServer which takes ResponseProvider. This function will be used by EG tests and reused by other response provider util functions. BUG=612957 Committed: https://crrev.com/56e1f38bb93dac4fd3ef4b7645b28486546ba658 Cr-Commit-Position: refs/heads/master@{#408504}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M ios/web/public/test/http_server_util.h View 2 chunks +7 lines, -0 lines 0 comments Download
M ios/web/public/test/http_server_util.mm View 1 chunk +7 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Eugene But (OOO till 7-30)
This is needed by redirect EG test: https://codereview.chromium.org/2190153002/
4 years, 4 months ago (2016-07-28 21:53:22 UTC) #4
baxley
lgtm
4 years, 4 months ago (2016-07-28 21:59:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193543002/1
4 years, 4 months ago (2016-07-28 22:39:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 22:43:49 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 22:46:36 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56e1f38bb93dac4fd3ef4b7645b28486546ba658
Cr-Commit-Position: refs/heads/master@{#408504}

Powered by Google App Engine
This is Rietveld 408576698