[ios] Implemented redirect EG tests for web shell.

[ios] Implemented redirect EG tests for web shell.

BUG=612957
Committed: https://crrev.com/a2c63c6f2315e9eeee138ff4ae687332046536b9
Cr-Commit-Position: refs/heads/master@{#408531}

[Eugene But (OOO till 7-30), 2016-07-28 21:52:34]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 21:53:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2016-07-28 21:53:37]

eugenebut@chromium.org changed reviewers:
+ baxley@chromium.org

[commit-bot: I haz the power, 2016-07-28 22:00:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 22:00:23]

Dry run: Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[baxley, 2016-07-28 22:06:38]

lgtm

https://codereview.chromium.org/2190153002/diff/1/ios/web/shell/test/redirect...
File ios/web/shell/test/redirect_egtest.mm (right):

https://codereview.chromium.org/2190153002/diff/1/ios/web/shell/test/redirect...
ios/web/shell/test/redirect_egtest.mm:52: // Load forst URL and expect
destination URL to load.
typo: s/forst/first

https://codereview.chromium.org/2190153002/diff/1/ios/web/shell/test/redirect...
ios/web/shell/test/redirect_egtest.mm:61: - (void)testRedirection301 {
What is the purpose of this test? Does the previous one cover the same thing?

Or is the purpose to see if simple redirects work, but multiple fail? If that's
valuable, then I think it's fine to have both tests.

https://codereview.chromium.org/2190153002/diff/1/ios/web/shell/test/redirect...
ios/web/shell/test/redirect_egtest.mm:76: // Load forst URL and expect
destination URL to load.
typo: first

https://codereview.chromium.org/2190153002/diff/1/ios/web/shell/test/redirect...
ios/web/shell/test/redirect_egtest.mm:93: const char kFinalPageContent[] =
"testRedirection301 complete";
s/301/302 ?

https://codereview.chromium.org/2190153002/diff/1/ios/web/shell/test/redirect...
ios/web/shell/test/redirect_egtest.mm:100: // Load forst URL and expect
destination URL to load.
first! :)

[Eugene But (OOO till 7-30), 2016-07-28 22:13:35]

Thanks!

https://codereview.chromium.org/2190153002/diff/1/ios/web/shell/test/redirect...
File ios/web/shell/test/redirect_egtest.mm (right):

https://codereview.chromium.org/2190153002/diff/1/ios/web/shell/test/redirect...
ios/web/shell/test/redirect_egtest.mm:52: // Load forst URL and expect
destination URL to load.
On 2016/07/28 22:06:37, baxley wrote:
> typo: s/forst/first

Done.

https://codereview.chromium.org/2190153002/diff/1/ios/web/shell/test/redirect...
ios/web/shell/test/redirect_egtest.mm:61: - (void)testRedirection301 {
On 2016/07/28 22:06:37, baxley wrote:
> What is the purpose of this test? Does the previous one cover the same thing?
> 
> Or is the purpose to see if simple redirects work, but multiple fail? If
that's
> valuable, then I think it's fine to have both tests.
I think redirect chain is more complex flow and it is still interesting to know
if the problem is related to a single 301 redirect or to a redirect chain.

https://codereview.chromium.org/2190153002/diff/1/ios/web/shell/test/redirect...
ios/web/shell/test/redirect_egtest.mm:76: // Load forst URL and expect
destination URL to load.
On 2016/07/28 22:06:37, baxley wrote:
> typo: first

Done.

https://codereview.chromium.org/2190153002/diff/1/ios/web/shell/test/redirect...
ios/web/shell/test/redirect_egtest.mm:93: const char kFinalPageContent[] =
"testRedirection301 complete";
On 2016/07/28 22:06:37, baxley wrote:
> s/301/302 ?

Done.

https://codereview.chromium.org/2190153002/diff/1/ios/web/shell/test/redirect...
ios/web/shell/test/redirect_egtest.mm:100: // Load forst URL and expect
destination URL to load.
On 2016/07/28 22:06:37, baxley wrote:
> first! :)

Done.

[Eugene But (OOO till 7-30), 2016-07-28 22:38:45]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 22:39:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 23:40:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 23:40:17]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2016-07-29 00:35:04]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-07-29 00:35:04]

The patchset sent to the CQ was uploaded after l-g-t-m from baxley@chromium.org
Link to the patchset: https://codereview.chromium.org/2190153002/#ps20001
(title: "Addressed review comments")

[commit-bot: I haz the power, 2016-07-29 00:35:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 00:39:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-29 00:42:03]

Description was changed from

==========
[ios] Implemented redirect EG tests for web shell.

BUG=612957
==========

to

==========
[ios] Implemented redirect EG tests for web shell.

BUG=612957

Committed: https://crrev.com/a2c63c6f2315e9eeee138ff4ae687332046536b9
Cr-Commit-Position: refs/heads/master@{#408531}
==========

[commit-bot: I haz the power, 2016-07-29 00:42:04]

Patchset 2 (id:??) landed as
https://crrev.com/a2c63c6f2315e9eeee138ff4ae687332046536b9
Cr-Commit-Position: refs/heads/master@{#408531}