Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2193383002: [Material][Mac] Fixed App Bookmark Item highlight (Closed)

Created:
4 years, 4 months ago by spqchan
Modified:
4 years, 4 months ago
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Material][Mac] Fixed App Bookmark Item highlight BUG=630959 Committed: https://crrev.com/131f85cadf19ef25e9eafc14e39230cee35e7305 Cr-Commit-Position: refs/heads/master@{#409708}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
spqchan
PTAL
4 years, 4 months ago (2016-07-29 19:48:58 UTC) #2
spqchan
ping, this is a release blocker
4 years, 4 months ago (2016-08-03 18:11:07 UTC) #3
shrike
lgtm
4 years, 4 months ago (2016-08-03 21:23:56 UTC) #4
spqchan
thanks! +avi for OWNERS
4 years, 4 months ago (2016-08-04 00:00:56 UTC) #6
Avi (use Gerrit)
lgtm stampity stamp
4 years, 4 months ago (2016-08-04 00:34:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193383002/1
4 years, 4 months ago (2016-08-04 02:02:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 02:36:24 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 02:39:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/131f85cadf19ef25e9eafc14e39230cee35e7305
Cr-Commit-Position: refs/heads/master@{#409708}

Powered by Google App Engine
This is Rietveld 408576698