Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3508)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Issue 2193383002: [Material][Mac] Fixed App Bookmark Item highlight (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
index f09e8fc25700e719361f215453e064db29c5137b..0ddbeff43752da5c0639092d5ba110e8dbe8a73c 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
@@ -1971,10 +1971,12 @@ CGFloat BookmarkRightMargin() {
[BookmarkButtonCell buttonCellWithText:text
image:image
menuController:contextMenuController_];
- if (ui::MaterialDesignController::IsModeMaterial())
+ if (ui::MaterialDesignController::IsModeMaterial()) {
[cell setTag:kMaterialStandardButtonTypeWithLimitedClickFeedback];
- else
+ [cell setHighlightsBy:NSNoCellMask];
+ } else {
[cell setTag:kStandardButtonTypeWithLimitedClickFeedback];
+ }
// Note: a quirk of setting a cell's text color is that it won't work
// until the cell is associated with a button, so we can't theme the cell yet.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698