third_party/WebKit/Source/modules/payments/PaymentUpdater.h - Issue 2193183002: Print proper debug message in case of change event timeout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentUpdater.h

Issue 2193183002: Print proper debug message in case of change event timeout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp ('K') | « third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentUpdater.h

diff --git a/third_party/WebKit/Source/modules/payments/PaymentUpdater.h b/third_party/WebKit/Source/modules/payments/PaymentUpdater.h

index b71a2c3be600912b8d357b17a8ad01be9754cf00..7128a781b8bf96523dc6960b1ffb52e87e7b76a0 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentUpdater.h

+++ b/third_party/WebKit/Source/modules/payments/PaymentUpdater.h

@@ -16,6 +16,7 @@ class MODULES_EXPORT PaymentUpdater : public GarbageCollectedMixin {

public:

virtual void onUpdatePaymentDetails(const ScriptValue& detailsScriptValue) = 0;

virtual void onUpdatePaymentDetailsFailure(const ScriptValue& error) = 0;

please use gerrit instead 2016/07/29 15:40:51 Change ScriptValue to String

pals 2016/08/01 11:18:23 Done.

+ virtual void abortPaymentRequest(const String& error) = 0;

please use gerrit instead 2016/07/29 15:40:50 No need for extra function.

pals 2016/08/01 11:18:23 Done.

protected:

virtual ~PaymentUpdater() {}