third_party/WebKit/Source/modules/payments/PaymentUpdater.h - Issue 2193183002: Print proper debug message in case of change event timeout.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/payments/PaymentUpdater.h

Issue 2193183002: Print proper debug message in case of change event timeout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp ('K') | « third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef PaymentUpdater_h	5 #ifndef PaymentUpdater_h

6 #define PaymentUpdater_h	6 #define PaymentUpdater_h

7	7

8 #include "modules/ModulesExport.h"	8 #include "modules/ModulesExport.h"

9 #include "platform/heap/GarbageCollected.h"	9 #include "platform/heap/GarbageCollected.h"
	please use gerrit instead 2016/07/29 15:40:50 #include "wtf/text/WTFString.h" #include "wtf/text/WTFString.h" pals 2016/08/01 11:18:23 Done. Show quoted text On 2016/07/29 15:40:50, rouslan wrote: > #include "wtf/text/WTFString.h" Done.
10	10

11 namespace blink {	11 namespace blink {

12	12

13 class ScriptValue;	13 class ScriptValue;

14	14

15 class MODULES_EXPORT PaymentUpdater : public GarbageCollectedMixin {	15 class MODULES_EXPORT PaymentUpdater : public GarbageCollectedMixin {

16 public:	16 public:

17 virtual void onUpdatePaymentDetails(const ScriptValue& detailsScriptValue) = 0;	17 virtual void onUpdatePaymentDetails(const ScriptValue& detailsScriptValue) = 0;

18 virtual void onUpdatePaymentDetailsFailure(const ScriptValue& error) = 0;	18 virtual void onUpdatePaymentDetailsFailure(const ScriptValue& error) = 0;
	please use gerrit instead 2016/07/29 15:40:51 Change ScriptValue to String Change ScriptValue to String pals 2016/08/01 11:18:23 Done. Show quoted text On 2016/07/29 15:40:51, rouslan wrote: > Change ScriptValue to String Done.
	19 virtual void abortPaymentRequest(const String& error) = 0;
	please use gerrit instead 2016/07/29 15:40:50 No need for extra function. No need for extra function. pals 2016/08/01 11:18:23 Done. Show quoted text On 2016/07/29 15:40:50, rouslan wrote: > No need for extra function. Done.
19	20

20 protected:	21 protected:

21 virtual ~PaymentUpdater() {}	22 virtual ~PaymentUpdater() {}

22 };	23 };

23	24

24 } // namespace blink	25 } // namespace blink

25	26

26 #endif // PaymentUpdater_h	27 #endif // PaymentUpdater_h

OLD	NEW