Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2193073004: Use inline layout object accessor for better code readability. (Closed)

Created:
4 years, 4 months ago by wkorman
Modified:
4 years, 4 months ago
Reviewers:
pdr., dgrogan
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use inline layout object accessor for better code readability. Committed: https://crrev.com/dc54866f1fb11689b4a97156a421ceda69688d01 Cr-Commit-Position: refs/heads/master@{#408783}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 6 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
wkorman
4 years, 4 months ago (2016-07-29 19:55:37 UTC) #2
pdr.
On 2016/07/29 at 19:55:37, wkorman wrote: > LGTM
4 years, 4 months ago (2016-07-29 19:56:37 UTC) #5
dgrogan
lgtm
4 years, 4 months ago (2016-07-29 21:08:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193073004/1
4 years, 4 months ago (2016-07-29 22:18:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 22:23:34 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 22:27:10 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc54866f1fb11689b4a97156a421ceda69688d01
Cr-Commit-Position: refs/heads/master@{#408783}

Powered by Google App Engine
This is Rietveld 408576698