third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h - Issue 2193073004: Use inline layout object accessor for better code readability.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h

Issue 2193073004: Use inline layout object accessor for better code readability. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef InlineTextBoxPainter_h	5 #ifndef InlineTextBoxPainter_h

6 #define InlineTextBoxPainter_h	6 #define InlineTextBoxPainter_h

7	7

8 #include "core/style/ComputedStyleConstants.h"	8 #include "core/style/ComputedStyleConstants.h"

9 #include "platform/geometry/LayoutRect.h"	9 #include "platform/geometry/LayoutRect.h"

10 #include "wtf/Allocator.h"	10 #include "wtf/Allocator.h"

(...skipping 37 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
48 void paintCompositionBackgrounds(GraphicsContext&, const LayoutPoint& boxOri gin, const ComputedStyle&, const Font&, bool useCustomUnderlines);	48 void paintCompositionBackgrounds(GraphicsContext&, const LayoutPoint& boxOri gin, const ComputedStyle&, const Font&, bool useCustomUnderlines);

49 void paintSingleCompositionBackgroundRun(GraphicsContext&, const LayoutPoint & boxOrigin, const ComputedStyle&, const Font&, Color backgroundColor, int start Pos, int endPos);	49 void paintSingleCompositionBackgroundRun(GraphicsContext&, const LayoutPoint & boxOrigin, const ComputedStyle&, const Font&, Color backgroundColor, int start Pos, int endPos);

50 template <PaintOptions>	50 template <PaintOptions>

51 void paintSelection(GraphicsContext&, const LayoutRect& boxRect, const Compu tedStyle&, const Font&, Color textColor, LayoutTextCombine* = nullptr);	51 void paintSelection(GraphicsContext&, const LayoutRect& boxRect, const Compu tedStyle&, const Font&, Color textColor, LayoutTextCombine* = nullptr);

52 void paintDecoration(const PaintInfo&, const LayoutPoint& boxOrigin, TextDec oration);	52 void paintDecoration(const PaintInfo&, const LayoutPoint& boxOrigin, TextDec oration);

53 void paintCompositionUnderline(GraphicsContext&, const LayoutPoint& boxOrigi n, const CompositionUnderline&);	53 void paintCompositionUnderline(GraphicsContext&, const LayoutPoint& boxOrigi n, const CompositionUnderline&);

54 unsigned underlinePaintStart(const CompositionUnderline&);	54 unsigned underlinePaintStart(const CompositionUnderline&);

55 unsigned underlinePaintEnd(const CompositionUnderline&);	55 unsigned underlinePaintEnd(const CompositionUnderline&);

56 bool shouldPaintTextBox(const PaintInfo&);	56 bool shouldPaintTextBox(const PaintInfo&);

57 void expandToIncludeNewlineForSelection(LayoutRect&);	57 void expandToIncludeNewlineForSelection(LayoutRect&);

	58 LayoutObject& inlineLayoutObject() const;

58	59

59 const InlineTextBox& m_inlineTextBox;	60 const InlineTextBox& m_inlineTextBox;

60 };	61 };

61	62

62 } // namespace blink	63 } // namespace blink

63	64

64 #endif // InlineTextBoxPainter_h	65 #endif // InlineTextBoxPainter_h

OLD	NEW