Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: chrome/test/data/webui/settings/privacy_page_test.js

Issue 2193073002: Fix CrSettingsPrivacyPageTest.PrivacyPage test failure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_data.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/privacy_page_test.js
diff --git a/chrome/test/data/webui/settings/privacy_page_test.js b/chrome/test/data/webui/settings/privacy_page_test.js
index 9408b166eb77d3f60187c3dc003825a03d34dfaf..3980e61691fbd9cb576c88c84fcfb495f436e582 100644
--- a/chrome/test/data/webui/settings/privacy_page_test.js
+++ b/chrome/test/data/webui/settings/privacy_page_test.js
@@ -183,15 +183,18 @@ cr.define('settings_privacy_page', function() {
MockInteractions.tap(noticeActionButton);
- // Tapping the action button will close the notice. Move to the
- // end of the message loop to allow the closing event to propagate
- // to the parent dialog. The parent dialog should subsequently
- // close as well.
- setTimeout(function() {
- var notice = element.$$('#notice');
- assertFalse(!!notice);
- assertFalse(element.$.dialog.open);
- }, 0);
+ return new Promise(function(resolve, reject) {
+ // Tapping the action button will close the notice. Move to the
+ // end of the message loop to allow the closing event to
+ // propagate to the parent dialog. The parent dialog should
+ // subsequently close as well.
+ setTimeout(function() {
+ var notice = element.$$('#notice');
+ assertFalse(!!notice);
+ assertFalse(element.$.dialog.open);
+ resolve();
+ }, 0);
+ });
});
});
« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_data.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698