Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: chrome/browser/resources/settings/site_settings/site_data.js

Issue 2193073002: Fix CrSettingsPrivacyPageTest.PrivacyPage test failure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings/site_data.js
diff --git a/chrome/browser/resources/settings/site_settings/site_data.js b/chrome/browser/resources/settings/site_settings/site_data.js
index ef86f1de35c452c7393a3d84b650571f77c883fb..157da97de06eed3e20c55240ffd5c4fef68c38ee 100644
--- a/chrome/browser/resources/settings/site_settings/site_data.js
+++ b/chrome/browser/resources/settings/site_settings/site_data.js
@@ -84,11 +84,8 @@ Polymer({
var node = this.treeNodes_.fetchNodeById(event.model.item.id, false);
dialog.open(node);
- dialog.addEventListener('iron-overlay-closed', function(event) {
- // The drop-down box in the dialog also generates iron-overlay-closed.
- // Ignore anything but that event coming from a dialog object.
- if (event.path[0].id == 'dialog')
- dialog.remove();
+ dialog.addEventListener('close', function(event) {
+ dialog.remove();
});
},
});

Powered by Google App Engine
This is Rietveld 408576698