Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 219303002: Revert 20313 - "Ship promises and weak collections" (Closed)

Created:
6 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 8 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -232 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 8 chunks +25 lines, -23 lines 0 comments Download
M src/flag-definitions.h View 2 chunks +8 lines, -1 line 0 comments Download
M src/promise.js View 6 chunks +19 lines, -17 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-microtask-delivery.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/debug-script.js View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/es6/microtask-delivery.js View 1 chunk +0 lines, -168 lines 0 comments Download
M test/mjsunit/es6/promises.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/regress/regress-2034.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/es6/regress/regress-2156.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/regress/regress-2829.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/es6/weak_collections.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es7/object-observe.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/harmony/collections.js View 2 chunks +7 lines, -8 lines 0 comments Download
A + test/mjsunit/harmony/microtask-delivery.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/private.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/proxies-hash.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regress/regress-observe-empty-double-array.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/symbols.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-350864.js View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-03-31 12:23:57 UTC) #1
rossberg
lgtm
6 years, 8 months ago (2014-03-31 12:34:05 UTC) #2
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-03-31 12:41:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20353 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698