Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 206163004: Ship promises and weak collections (Closed)

Created:
6 years, 9 months ago by rossberg
Modified:
6 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, yhirano, jochen (gone - plz use gerrit)
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -253 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 8 chunks +23 lines, -25 lines 0 comments Download
M src/flag-definitions.h View 2 chunks +1 line, -8 lines 0 comments Download
M src/promise.js View 7 chunks +19 lines, -22 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-microtask-delivery.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/debug-script.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/microtask-delivery.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/promises.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/regress/regress-2034.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/regress/regress-2156.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/regress/regress-2829.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/weak_collections.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es7/object-observe.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/harmony/collections.js View 2 chunks +8 lines, -7 lines 0 comments Download
D test/mjsunit/harmony/microtask-delivery.js View 1 chunk +0 lines, -168 lines 0 comments Download
M test/mjsunit/harmony/private.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/proxies-hash.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regress/regress-observe-empty-double-array.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/symbols.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-350864.js View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rossberg
6 years, 9 months ago (2014-03-24 15:15:55 UTC) #1
Michael Starzinger
LGTM.
6 years, 9 months ago (2014-03-24 16:45:46 UTC) #2
rossberg
Committed patchset #1 manually as r20211 (presubmit successful).
6 years, 9 months ago (2014-03-24 16:59:25 UTC) #3
rossberg
6 years, 9 months ago (2014-03-27 16:43:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r20313 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698