Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2192923003: [Mac/GN] Fix gn gen when using_sanitizer=true use_custom_libcxx=true. (Closed)

Created:
4 years, 4 months ago by Robert Sesek
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Fix gn gen when using_sanitizer=true use_custom_libcxx=true. BUG=630322 R=dpranke@chromium.org Committed: https://crrev.com/3d6e18f08b7abe178e7abd6babee202b5a763e45 Cr-Commit-Position: refs/heads/master@{#408459}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M build/config/sanitizers/BUILD.gn View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Robert Sesek
4 years, 4 months ago (2016-07-28 19:09:18 UTC) #1
Dirk Pranke
lgtm
4 years, 4 months ago (2016-07-28 19:13:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192923003/1
4 years, 4 months ago (2016-07-28 20:16:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 20:20:35 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 20:21:44 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d6e18f08b7abe178e7abd6babee202b5a763e45
Cr-Commit-Position: refs/heads/master@{#408459}

Powered by Google App Engine
This is Rietveld 408576698