Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3145)

Unified Diff: build/config/sanitizers/BUILD.gn

Issue 2192923003: [Mac/GN] Fix gn gen when using_sanitizer=true use_custom_libcxx=true. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/sanitizers/BUILD.gn
diff --git a/build/config/sanitizers/BUILD.gn b/build/config/sanitizers/BUILD.gn
index 2c490165f2b237a282aa3772a1ae7c2d63d190f6..65ed872e9840cd4e0970b3adee127c33a5fc3d7f 100644
--- a/build/config/sanitizers/BUILD.gn
+++ b/build/config/sanitizers/BUILD.gn
@@ -42,6 +42,7 @@ group("deps_no_options") {
":default_sanitizer_ldflags",
]
deps = []
+ public_deps = []
data = [
"//tools/valgrind/asan/",
@@ -62,9 +63,7 @@ group("deps_no_options") {
deps += [ "//third_party/instrumented_libraries:deps" ]
}
if (use_custom_libcxx) {
- public_deps = [
- "//buildtools/third_party/libc++:libcxx_proxy",
- ]
+ public_deps += [ "//buildtools/third_party/libc++:libcxx_proxy" ]
data += [ "$root_out_dir/libc++.so" ]
}
if (is_mac) {
@@ -72,9 +71,7 @@ group("deps_no_options") {
":copy_asan_runtime",
]
- public_deps = [
- ":asan_runtime_bundle_data",
- ]
+ public_deps += [ ":asan_runtime_bundle_data" ]
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698