Add writeToMemory() API to SkColorSpace

Add writeToMemory() API to SkColorSpace

New API mirrors the form of similar APIs in SkRegion,
SkMatrix, etc.

This also fixes a bug:
SkImageInfo appears in a object that Chrome stores in
discardable memory. So when sk_sp<SkColorSpace> was added
to SkImageInfo a leak was introduced. We'll use this new
method and deserialize to store the SkColorSpace in the
discardable object.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2192903002

Committed: https://skia.googlesource.com/skia/+/a0605bf9d13f5758a6fa2fa366c4dc5341c2cf61

[msarett, 2016-07-28 16:12:45]

Description was changed from

==========
Add serializeInPlace() API to SkColorSpace

BUG=skia:
==========

to

==========
Add serializeInPlace() API to SkColorSpace

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2192903002
==========

[msarett, 2016-07-28 16:14:40]

msarett@google.com changed reviewers:
+ bsalomon@google.com, reed@google.com

[msarett, 2016-07-28 16:15:12]

Description was changed from

==========
Add serializeInPlace() API to SkColorSpace

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2192903002
==========

to

==========
Add serializeInPlace() API to SkColorSpace

Allows SkColorSpace to be stored in discardable
memory without leaking.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2192903002
==========

[bsalomon, 2016-07-28 16:18:05]

This looks like it will work for the DeferredTextureImage use case. Thanks! lgtm

[reed1, 2016-07-28 16:18:29]

we call this writeToMemory in a couple of other classes (e.g. SkRegion,
SkMatrix). Is there a reason to standardize on a name for this idea?

else lgtm

[reed1, 2016-07-28 16:19:00]

not sure what "discardable" and "leaking" have to do with the CL per-se

[msarett, 2016-07-28 16:19:11]

On 2016/07/28 16:18:29, reed1 wrote:
> we call this writeToMemory in a couple of other classes (e.g. SkRegion,
> SkMatrix). Is there a reason to standardize on a name for this idea?
> 
> else lgtm

writeToMemory SGTM

[bsalomon, 2016-07-28 16:21:06]

On 2016/07/28 16:19:00, reed1 wrote:
> not sure what "discardable" and "leaking" have to do with the CL per-se

SkImageInfo appears in a object that Chrome stores in discardable memory. So
when sk_sp<SkColorSpace> was added to SkImageInfo a leak was introduced. We'll
use this new method and deserialize to store the SkColorSpace in the discardable
object.

[msarett, 2016-07-28 16:21:30]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 16:21:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-07-28 16:29:18]

On 2016/07/28 16:21:06, bsalomon wrote:
> On 2016/07/28 16:19:00, reed1 wrote:
> > not sure what "discardable" and "leaking" have to do with the CL per-se
> 
> SkImageInfo appears in a object that Chrome stores in discardable memory. So
> when sk_sp<SkColorSpace> was added to SkImageInfo a leak was introduced. We'll
> use this new method and deserialize to store the SkColorSpace in the
discardable
> object.

sg -- perhaps the CL desc can reflect that. Or perhaps a bug noting the leak.
Just for a code-review / api perspective, I think the CL desc can focus more
just on the api change/addition and how we will test it... do we have a
unit-test for this?

[msarett, 2016-07-28 16:31:47]

On 2016/07/28 16:29:18, reed1 wrote:
> On 2016/07/28 16:21:06, bsalomon wrote:
> > On 2016/07/28 16:19:00, reed1 wrote:
> > > not sure what "discardable" and "leaking" have to do with the CL per-se
> > 
> > SkImageInfo appears in a object that Chrome stores in discardable memory. So
> > when sk_sp<SkColorSpace> was added to SkImageInfo a leak was introduced.
We'll
> > use this new method and deserialize to store the SkColorSpace in the
> discardable
> > object.
> 
> sg -- perhaps the CL desc can reflect that. Or perhaps a bug noting the leak.
> Just for a code-review / api perspective, I think the CL desc can focus more
> just on the api change/addition and how we will test it... do we have a
> unit-test for this?

We have a serizlize/Deserialize unit test that continues to pass.  I'll
add a test for this new API as well.

[msarett, 2016-07-28 16:38:25]

Description was changed from

==========
Add serializeInPlace() API to SkColorSpace

Allows SkColorSpace to be stored in discardable
memory without leaking.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2192903002
==========

to

==========
Add writeToMemory() API to SkColorSpace

Allows SkColorSpace to be stored in discardable
memory without leaking.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2192903002
==========

[msarett, 2016-07-28 16:39:38]

Description was changed from

==========
Add writeToMemory() API to SkColorSpace

Allows SkColorSpace to be stored in discardable
memory without leaking.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2192903002
==========

to

==========
Add writeToMemory() API to SkColorSpace

New API mirrors the form of similar APIs in 

SkImageInfo appears in a object that Chrome stores in
discardable memory. So when sk_sp<SkColorSpace> was added
to SkImageInfo a leak was introduced. We'll use this new
method and deserialize to store the SkColorSpace in the
discardable object.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2192903002
==========

[msarett, 2016-07-28 16:40:34]

Description was changed from

==========
Add writeToMemory() API to SkColorSpace

New API mirrors the form of similar APIs in 

SkImageInfo appears in a object that Chrome stores in
discardable memory. So when sk_sp<SkColorSpace> was added
to SkImageInfo a leak was introduced. We'll use this new
method and deserialize to store the SkColorSpace in the
discardable object.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2192903002
==========

to

==========
Add writeToMemory() API to SkColorSpace

New API mirrors the form of similar APIs in SkRegion,
SkMatrix, etc.

This also fixes a bug:
SkImageInfo appears in a object that Chrome stores in
discardable memory. So when sk_sp<SkColorSpace> was added
to SkImageInfo a leak was introduced. We'll use this new
method and deserialize to store the SkColorSpace in the
discardable object.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2192903002
==========

[msarett, 2016-07-28 16:42:36]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 16:42:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msarett, 2016-07-28 16:42:52]

Added a unit test and updated the CL description.

[commit-bot: I haz the power, 2016-07-28 17:40:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 17:40:24]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-07-28 17:45:06]

The CQ bit was checked by msarett@google.com

[msarett, 2016-07-28 17:45:07]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com,
reed@google.com
Link to the patchset: https://codereview.chromium.org/2192903002/#ps40001
(title: "Added unit test")

[commit-bot: I haz the power, 2016-07-28 17:45:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 17:47:52]

Description was changed from

==========
Add writeToMemory() API to SkColorSpace

New API mirrors the form of similar APIs in SkRegion,
SkMatrix, etc.

This also fixes a bug:
SkImageInfo appears in a object that Chrome stores in
discardable memory. So when sk_sp<SkColorSpace> was added
to SkImageInfo a leak was introduced. We'll use this new
method and deserialize to store the SkColorSpace in the
discardable object.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2192903002
==========

to

==========
Add writeToMemory() API to SkColorSpace

New API mirrors the form of similar APIs in SkRegion,
SkMatrix, etc.

This also fixes a bug:
SkImageInfo appears in a object that Chrome stores in
discardable memory. So when sk_sp<SkColorSpace> was added
to SkImageInfo a leak was introduced. We'll use this new
method and deserialize to store the SkColorSpace in the
discardable object.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2192903002

Committed:
https://skia.googlesource.com/skia/+/a0605bf9d13f5758a6fa2fa366c4dc5341c2cf61
==========

[commit-bot: I haz the power, 2016-07-28 17:47:53]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/a0605bf9d13f5758a6fa2fa366c4dc5341c2cf61