Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2192823002: Splitting fpdfdoc/doc_* part I (Closed)

Created:
4 years, 4 months ago by dsinclair
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com, npm
Base URL:
https://pdfium.googlesource.com/pdfium.git@fpdf_doc_II
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Splitting fpdfdoc/doc_* part I The first of several CLs to split the core/fpdfdoc/doc_* files up to individual class files. Committed: https://pdfium.googlesource.com/pdfium/+/02e6f5957a56ea492961aef71b3c16cf42ea5998

Patch Set 1 #

Patch Set 2 : Rebase to master #

Patch Set 3 : Fixup gyp files #

Patch Set 4 : Add stdint.h #

Patch Set 5 : Stddef not stdint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+397 lines, -624 lines) Patch
M BUILD.gn View 1 2 3 2 chunks +10 lines, -5 lines 0 comments Download
A core/fpdfdoc/cpdf_aaction.cpp View 1 chunk +24 lines, -0 lines 0 comments Download
A core/fpdfdoc/cpdf_action.cpp View 1 chunk +137 lines, -0 lines 0 comments Download
A core/fpdfdoc/cpdf_actionfields.cpp View 1 chunk +96 lines, -0 lines 0 comments Download
A + core/fpdfdoc/cpdf_bookmark.cpp View 5 chunks +8 lines, -41 lines 0 comments Download
A core/fpdfdoc/cpdf_bookmarktree.cpp View 1 chunk +34 lines, -0 lines 0 comments Download
A core/fpdfdoc/cpdf_docjsactions.cpp View 1 chunk +40 lines, -0 lines 0 comments Download
A core/fpdfdoc/cpdf_link.cpp View 1 chunk +32 lines, -0 lines 0 comments Download
A + core/fpdfdoc/cpdf_linklist.cpp View 2 chunks +2 lines, -26 lines 0 comments Download
A + core/fpdfdoc/cpdf_metadata.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfdoc/cpdf_viewerpreferences.cpp View 1 chunk +1 line, -1 line 0 comments Download
D core/fpdfdoc/doc_action.cpp View 1 chunk +0 lines, -271 lines 0 comments Download
D core/fpdfdoc/doc_bookmark.cpp View 1 chunk +0 lines, -104 lines 0 comments Download
D core/fpdfdoc/doc_link.cpp View 1 chunk +0 lines, -94 lines 0 comments Download
D core/fpdfdoc/doc_metadata.cpp View 1 chunk +0 lines, -32 lines 0 comments Download
D core/fpdfdoc/doc_viewerPreferences.cpp View 1 chunk +0 lines, -44 lines 0 comments Download
M core/fpdfdoc/include/cpdf_actionfields.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 2 3 2 chunks +10 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 28 (21 generated)
dsinclair
PTAL.
4 years, 4 months ago (2016-07-28 14:24:59 UTC) #4
Lei Zhang
GYP builds are borked.
4 years, 4 months ago (2016-07-28 20:44:21 UTC) #13
Lei Zhang
Still got red bots, but lgtm with the right IWYU fix.
4 years, 4 months ago (2016-07-28 21:41:41 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192823002/60001
4 years, 4 months ago (2016-08-02 17:38:29 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_xfa_rel_gyp on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa_rel_gyp/builds/159)
4 years, 4 months ago (2016-08-02 17:50:16 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192823002/80001
4 years, 4 months ago (2016-08-02 18:05:50 UTC) #26
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 18:25:52 UTC) #28
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/02e6f5957a56ea492961aef71b3c16cf42ea...

Powered by Google App Engine
This is Rietveld 408576698