Splitting fpdfdoc/doc_* part II.

Splitting fpdfdoc/doc_* part II.

This splits the doc_ocg, doc_vt and doc_basic files into individual class files.

Committed: https://pdfium.googlesource.com/pdfium/+/448c4337f2be2523727451b265311d48e9550ee5

[dsinclair, 2016-07-28 18:30:29]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, weili@chromium.org

[dsinclair, 2016-07-28 18:30:29]

PTAL.

[dsinclair, 2016-07-28 20:23:43]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 20:23:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 20:51:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 20:51:22]

Dry run: Try jobs failed on following builders:
  win_xfa_rel_gyp on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa_rel_gyp...)

[Lei Zhang, 2016-07-28 21:50:04]

Still got red bots. More rebasing needed?

https://codereview.chromium.org/2187073005/diff/20001/core/fpdfdoc/cpdf_pagel...
File core/fpdfdoc/cpdf_pagelabel.cpp (right):

https://codereview.chromium.org/2187073005/diff/20001/core/fpdfdoc/cpdf_pagel...
core/fpdfdoc/cpdf_pagelabel.cpp:17: const int arabic[] = {1000, 900, 500, 400,
100, 90, 50, 40, 10, 9, 5, 4, 1};
kFoo

https://codereview.chromium.org/2187073005/diff/20001/core/fpdfdoc/cpdf_pagel...
core/fpdfdoc/cpdf_pagelabel.cpp:42: num -= 1;
--num;

https://codereview.chromium.org/2187073005/diff/20001/core/fpdfdoc/cpvt_array...
File core/fpdfdoc/cpvt_arraytemplate.h (right):

https://codereview.chromium.org/2187073005/diff/20001/core/fpdfdoc/cpvt_array...
core/fpdfdoc/cpvt_arraytemplate.h:16: FX_BOOL IsEmpty() { return
CFX_ArrayTemplate<TYPE>::GetSize() <= 0; }
Do you think we can get away with making this a bool?

https://codereview.chromium.org/2187073005/diff/20001/core/fpdfdoc/include/cp...
File core/fpdfdoc/include/cpdf_variabletext.h (right):

https://codereview.chromium.org/2187073005/diff/20001/core/fpdfdoc/include/cp...
core/fpdfdoc/include/cpdf_variabletext.h:172: CFX_FloatPoint ptLeftTop =
InToOut(CFX_FloatPoint(rect.left, rect.top));
Feels like these should be moved out of the header.

https://codereview.chromium.org/2187073005/diff/20001/fpdfsdk/fxedit/fxet_edi...
File fpdfsdk/fxedit/fxet_edit.cpp (right):

https://codereview.chromium.org/2187073005/diff/20001/fpdfsdk/fxedit/fxet_edi...
fpdfsdk/fxedit/fxet_edit.cpp:2792: if (IsFloatBigger(rcContent.Height(),
rcPlate.Height()))
combine nested ifs?

https://codereview.chromium.org/2187073005/diff/20001/fpdfsdk/fxedit/include/...
File fpdfsdk/fxedit/include/fxet_edit.h (left):

https://codereview.chromium.org/2187073005/diff/20001/fpdfsdk/fxedit/include/...
fpdfsdk/fxedit/include/fxet_edit.h:27: #define FX_EDIT_IsFloatZero(f) (f <
0.0001 && f > -0.0001)
gahhhh

[dsinclair, 2016-08-02 17:55:48]

https://codereview.chromium.org/2187073005/diff/20001/core/fpdfdoc/cpdf_pagel...
File core/fpdfdoc/cpdf_pagelabel.cpp (right):

https://codereview.chromium.org/2187073005/diff/20001/core/fpdfdoc/cpdf_pagel...
core/fpdfdoc/cpdf_pagelabel.cpp:17: const int arabic[] = {1000, 900, 500, 400,
100, 90, 50, 40, 10, 9, 5, 4, 1};
On 2016/07/28 21:50:03, Lei Zhang wrote:
> kFoo

Done.

https://codereview.chromium.org/2187073005/diff/20001/core/fpdfdoc/cpdf_pagel...
core/fpdfdoc/cpdf_pagelabel.cpp:42: num -= 1;
On 2016/07/28 21:50:03, Lei Zhang wrote:
> --num;

Done.

https://codereview.chromium.org/2187073005/diff/20001/core/fpdfdoc/cpvt_array...
File core/fpdfdoc/cpvt_arraytemplate.h (right):

https://codereview.chromium.org/2187073005/diff/20001/core/fpdfdoc/cpvt_array...
core/fpdfdoc/cpvt_arraytemplate.h:16: FX_BOOL IsEmpty() { return
CFX_ArrayTemplate<TYPE>::GetSize() <= 0; }
On 2016/07/28 21:50:03, Lei Zhang wrote:
> Do you think we can get away with making this a bool?

Done.

https://codereview.chromium.org/2187073005/diff/20001/core/fpdfdoc/include/cp...
File core/fpdfdoc/include/cpdf_variabletext.h (right):

https://codereview.chromium.org/2187073005/diff/20001/core/fpdfdoc/include/cp...
core/fpdfdoc/include/cpdf_variabletext.h:172: CFX_FloatPoint ptLeftTop =
InToOut(CFX_FloatPoint(rect.left, rect.top));
On 2016/07/28 21:50:03, Lei Zhang wrote:
> Feels like these should be moved out of the header.

Done.

https://codereview.chromium.org/2187073005/diff/20001/fpdfsdk/fxedit/fxet_edi...
File fpdfsdk/fxedit/fxet_edit.cpp (right):

https://codereview.chromium.org/2187073005/diff/20001/fpdfsdk/fxedit/fxet_edi...
fpdfsdk/fxedit/fxet_edit.cpp:2792: if (IsFloatBigger(rcContent.Height(),
rcPlate.Height()))
On 2016/07/28 21:50:03, Lei Zhang wrote:
> combine nested ifs?

Done.

https://codereview.chromium.org/2187073005/diff/20001/fpdfsdk/fxedit/include/...
File fpdfsdk/fxedit/include/fxet_edit.h (left):

https://codereview.chromium.org/2187073005/diff/20001/fpdfsdk/fxedit/include/...
fpdfsdk/fxedit/include/fxet_edit.h:27: #define FX_EDIT_IsFloatZero(f) (f <
0.0001 && f > -0.0001)
On 2016/07/28 21:50:03, Lei Zhang wrote:
> gahhhh

What, there was only like 7 copies of this ......

[dsinclair, 2016-08-02 18:18:17]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 18:18:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-08-02 18:37:31]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 18:37:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-08-02 19:00:03]

lgtm

[dsinclair, 2016-08-02 19:03:13]

The CQ bit was unchecked by dsinclair@chromium.org

[dsinclair, 2016-08-02 19:03:14]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-08-02 19:03:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 19:07:37]

Description was changed from

==========
Splitting fpdfdoc/doc_* part II.

This splits the doc_ocg, doc_vt and doc_basic files into individual class files.
==========

to

==========
Splitting fpdfdoc/doc_* part II.

This splits the doc_ocg, doc_vt and doc_basic files into individual class files.

Committed:
https://pdfium.googlesource.com/pdfium/+/448c4337f2be2523727451b265311d48e955...
==========

[commit-bot: I haz the power, 2016-08-02 19:07:38]

Committed patchset #6 (id:100001) as
https://pdfium.googlesource.com/pdfium/+/448c4337f2be2523727451b265311d48e955...