Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2192613002: Moves NewWindowDelegate to ash/common (Closed)

Created:
4 years, 4 months ago by sky
Modified:
4 years, 4 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, elijahtaylor+arcwatch_chromium.org, michaelpg+watch-options_chromium.org, sadrul, yusukes+watch_chromium.org, michaelpg+watch-md-settings_chromium.org, hidehiko+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, kalyank, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves NewWindowDelegate to ash/common And updates accelerators appropriately. BUG=612331 TEST=none R=jamescook@chromium.org,stevenjb@chromium.org,reveman@chromium.org TBR=stevenjb@chromium.org,reveman@chromium.org Committed: https://crrev.com/a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb Cr-Commit-Position: refs/heads/master@{#408264}

Patch Set 1 #

Patch Set 2 : order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -200 lines) Patch
M ash/accelerators/accelerator_controller_delegate_aura.cc View 13 chunks +0 lines, -110 lines 0 comments Download
M ash/common/accelerators/accelerator_controller.cc View 1 11 chunks +98 lines, -0 lines 0 comments Download
A + ash/common/new_window_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/common/wm_shell.h View 3 chunks +6 lines, -0 lines 0 comments Download
M ash/common/wm_shell.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M ash/display/display_util.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/mus/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/mus/accelerators/accelerator_controller_delegate_mus.cc View 2 chunks +0 lines, -10 lines 0 comments Download
A ash/mus/new_window_delegate_mus.h View 1 chunk +37 lines, -0 lines 0 comments Download
A ash/mus/new_window_delegate_mus.cc View 1 chunk +63 lines, -0 lines 0 comments Download
M ash/mus/shell_delegate_mus.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D ash/new_window_delegate.h View 1 chunk +0 lines, -46 lines 0 comments Download
M ash/shell.h View 3 chunks +0 lines, -6 lines 0 comments Download
M ash/shell.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_shell_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_new_window_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_new_window_delegate_browsertest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/arc/intent_helper/arc_intent_helper_bridge.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 2183993005 Patch 1

Messages

Total messages: 20 (12 generated)
sky
4 years, 4 months ago (2016-07-27 20:59:51 UTC) #3
James Cook
LGTM
4 years, 4 months ago (2016-07-27 22:50:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192613002/20001
4 years, 4 months ago (2016-07-27 22:54:29 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/226560)
4 years, 4 months ago (2016-07-27 23:02:19 UTC) #10
sky
TBR stevenjb@chromium.org,reveman@chromium.org for trivial changes
4 years, 4 months ago (2016-07-27 23:04:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192613002/20001
4 years, 4 months ago (2016-07-27 23:05:03 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-27 23:08:59 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 23:12:23 UTC) #20
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a279c7c6f9c39d546588e2d1ffd80f9ea3c306cb
Cr-Commit-Position: refs/heads/master@{#408264}

Powered by Google App Engine
This is Rietveld 408576698