Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2183993005: Moves handling of toggling applist back to common code (Closed)

Created:
4 years, 4 months ago by sky
Modified:
4 years, 4 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@new_window_delegate
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves handling of toggling applist back to common code Implementation is no longer aura specific. BUG=612331 TEST=none R=jamescook@chromium.org Committed: https://crrev.com/6d4038f3350e3a2206801adbac1c31553157a38b Cr-Commit-Position: refs/heads/master@{#408284}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -34 lines) Patch
M ash/accelerators/accelerator_controller_delegate_aura.cc View 5 chunks +0 lines, -33 lines 0 comments Download
M ash/common/accelerators/accelerator_controller.cc View 3 chunks +31 lines, -0 lines 0 comments Download
M ash/mus/accelerators/accelerator_controller_delegate_mus.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sky
4 years, 4 months ago (2016-07-27 22:44:13 UTC) #1
James Cook
LGTM. Thanks for moving it back.
4 years, 4 months ago (2016-07-27 22:51:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183993005/20001
4 years, 4 months ago (2016-07-27 23:24:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-28 00:04:43 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 00:07:27 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6d4038f3350e3a2206801adbac1c31553157a38b
Cr-Commit-Position: refs/heads/master@{#408284}

Powered by Google App Engine
This is Rietveld 408576698