Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1436)

Issue 2192593002: [ios] Cleaned up web EG matchers. (Closed)

Created:
4 years, 4 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 4 months ago
Reviewers:
baxley
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@pdf_eg_test
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Cleaned up web EG matchers. 1.) Dropped Obj-C API as unused 2.) Pass std::string by value because they almost always used in blocks 3.) Consistently use C++ Style for variable naming 4.) Dropped namespace prefixing where unneeded BUG=None Committed: https://crrev.com/3cdca1694cb6bce8aa061dd1af5fcb9774737225 Cr-Commit-Position: refs/heads/master@{#408682}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -157 lines) Patch
M ios/web/public/test/earl_grey/web_view_matchers.h View 1 chunk +5 lines, -26 lines 0 comments Download
M ios/web/public/test/earl_grey/web_view_matchers.mm View 3 chunks +22 lines, -51 lines 0 comments Download
M ios/web/shell/test/earl_grey/shell_matchers.h View 1 chunk +8 lines, -33 lines 0 comments Download
M ios/web/shell/test/earl_grey/shell_matchers.mm View 4 chunks +14 lines, -47 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
Eugene But (OOO till 7-30)
4 years, 4 months ago (2016-07-27 22:51:36 UTC) #2
baxley
lgtm
4 years, 4 months ago (2016-07-27 23:01:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192593002/1
4 years, 4 months ago (2016-07-27 23:07:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/103200)
4 years, 4 months ago (2016-07-27 23:20:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192593002/1
4 years, 4 months ago (2016-07-29 17:19:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 17:52:34 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 17:53:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cdca1694cb6bce8aa061dd1af5fcb9774737225
Cr-Commit-Position: refs/heads/master@{#408682}

Powered by Google App Engine
This is Rietveld 408576698