[ios] EarlGrey test for PDF Mime type.

[ios] EarlGrey test for PDF Mime type.

BUG=631235
Committed: https://crrev.com/429d8cd2483466d900adee5067c3be1c23c4438c
Cr-Commit-Position: refs/heads/master@{#408260}

[Eugene But (OOO till 7-30), 2016-07-25 22:47:09]

eugenebut@chromium.org changed reviewers:
+ baxley@chromium.org

[baxley, 2016-07-26 18:21:37]

lgtm

https://codereview.chromium.org/2183583002/diff/20001/ios/web/shell/test/pdf_...
File ios/web/shell/test/pdf_egtest.mm (right):

https://codereview.chromium.org/2183583002/diff/20001/ios/web/shell/test/pdf_...
ios/web/shell/test/pdf_egtest.mm:34: [[EarlGrey
selectElementWithMatcher:web::webViewMimeType("application/pdf")]
Do you think this method is useful as a helper, where you put it?

1. If it's useful to other tests, it should definitely be in the utilities.
2. If it's super specific to this test then it shouldn't.
3. If it's generally useful, but we don't know how widespread I'm fine with
sharing it.

As long as it's not the second example I gave, I think it is fine as is.

[Eugene But (OOO till 7-30), 2016-07-27 01:15:47]

PTAL

https://codereview.chromium.org/2183583002/diff/20001/ios/web/shell/test/pdf_...
File ios/web/shell/test/pdf_egtest.mm (right):

https://codereview.chromium.org/2183583002/diff/20001/ios/web/shell/test/pdf_...
ios/web/shell/test/pdf_egtest.mm:34: [[EarlGrey
selectElementWithMatcher:web::webViewMimeType("application/pdf")]
On 2016/07/26 18:21:36, baxley wrote:
> Do you think this method is useful as a helper, where you put it?
> 
> 1. If it's useful to other tests, it should definitely be in the utilities.
> 2. If it's super specific to this test then it shouldn't.
> 3. If it's generally useful, but we don't know how widespread I'm fine with
> sharing it.
> 
> As long as it's not the second example I gave, I think it is fine as is.
I don't know the answer. I've made webViewInWebState public and webViewMimeType
local. We can always refactor later and make webViewMimeType public if
necessary.

Let me know if you want to have webViewInCurrentWebState in shell_matchers.h.

[baxley, 2016-07-27 20:08:43]

On 2016/07/27 01:15:47, Eugene But wrote:
> PTAL
> 
>
https://codereview.chromium.org/2183583002/diff/20001/ios/web/shell/test/pdf_...
> File ios/web/shell/test/pdf_egtest.mm (right):
> 
>
https://codereview.chromium.org/2183583002/diff/20001/ios/web/shell/test/pdf_...
> ios/web/shell/test/pdf_egtest.mm:34: [[EarlGrey
> selectElementWithMatcher:web::webViewMimeType("application/pdf")]
> On 2016/07/26 18:21:36, baxley wrote:
> > Do you think this method is useful as a helper, where you put it?
> > 
> > 1. If it's useful to other tests, it should definitely be in the utilities.
> > 2. If it's super specific to this test then it shouldn't.
> > 3. If it's generally useful, but we don't know how widespread I'm fine with
> > sharing it.
> > 
> > As long as it's not the second example I gave, I think it is fine as is.
> I don't know the answer. I've made webViewInWebState public and
webViewMimeType
> local. We can always refactor later and make webViewMimeType public if
> necessary.
> 
> Let me know if you want to have webViewInCurrentWebState in shell_matchers.h.

LGTM

[Eugene But (OOO till 7-30), 2016-07-27 20:10:42]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2016-07-27 20:11:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 20:16:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 20:16:54]

Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[Eugene But (OOO till 7-30), 2016-07-27 20:20:53]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-07-27 20:20:54]

The patchset sent to the CQ was uploaded after l-g-t-m from baxley@chromium.org
Link to the patchset: https://codereview.chromium.org/2183583002/#ps100001
(title: "Added missing dependencies.")

[commit-bot: I haz the power, 2016-07-27 20:21:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 20:27:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 20:27:55]

Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[Eugene But (OOO till 7-30), 2016-07-27 20:38:38]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-07-27 20:38:38]

The patchset sent to the CQ was uploaded after l-g-t-m from baxley@chromium.org
Link to the patchset: https://codereview.chromium.org/2183583002/#ps120001
(title: "Added missing GN dependency")

[commit-bot: I haz the power, 2016-07-27 20:38:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 22:50:28]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-07-27 22:52:56]

Description was changed from

==========
[ios] EarlGrey test for PDF Mime type.

BUG=631235
==========

to

==========
[ios] EarlGrey test for PDF Mime type.

BUG=631235

Committed: https://crrev.com/429d8cd2483466d900adee5067c3be1c23c4438c
Cr-Commit-Position: refs/heads/master@{#408260}
==========

[commit-bot: I haz the power, 2016-07-27 22:52:56]

Patchset 7 (id:??) landed as
https://crrev.com/429d8cd2483466d900adee5067c3be1c23c4438c
Cr-Commit-Position: refs/heads/master@{#408260}