mash: Convert ShelfWindowWatcher to wm common types

ash/shelf/shelf_window_watcher_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/shelf/shelf_window_watcher.h"
 
 #include "ash/aura/wm_window_aura.h"
 #include "ash/common/ash_switches.h"
 #include "ash/common/shelf/shelf_item_types.h"
 #include "ash/common/shelf/shelf_model.h"
@@ skipping 36 matching lines @@
     return id;
   }
 
  protected:
   ShelfModel* model_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ShelfWindowWatcherTest);
 };
 
-TEST_F(ShelfWindowWatcherTest, CreateAndRemoveShelfItem) {
+// Tests that shelf items are removed as windows are closed.
+TEST_F(ShelfWindowWatcherTest, OpenAndClose) {
   // ShelfModel only has an APP_LIST item.
   EXPECT_EQ(1, model_->item_count());
 
+  std::unique_ptr<aura::Window> w1(CreateTestWindowInShellWithId(0));
+  std::unique_ptr<aura::Window> w2(CreateTestWindowInShellWithId(0));
+
+  // Create a ShelfItem for w1.

[msw, 2016/07/27 18:36:11]

Is it possible to test that items are created when the windows are added to the
default container (perhaps instead of explicitly adding items like this)?

[James Cook, 2016/07/27 20:14:06]

Done (and thanks for the suggestion, it's better). I didn't convert all the
other tests to this approach, since if the CreateAndRemoveShelfItemDetails test
passes then the other tests should be OK with adding the details after window
creation.

+  CreateShelfItem(w1.get());
+  EXPECT_EQ(2, model_->item_count());
+
+  // Create a ShelfItem for w2.
+  CreateShelfItem(w2.get());
+  EXPECT_EQ(3, model_->item_count());
+
+  // Each ShelfItem is removed when the associated window is destroyed.
+  w1.reset();
+  EXPECT_EQ(2, model_->item_count());
+  w2.reset();
+  EXPECT_EQ(1, model_->item_count());
+}
+
+TEST_F(ShelfWindowWatcherTest, CreateAndRemoveShelfItemDetails) {
+  // ShelfModel only has an APP_LIST item.
+  EXPECT_EQ(1, model_->item_count());
+
   std::unique_ptr<aura::Window> w1(CreateTestWindowInShellWithId(0));
   std::unique_ptr<aura::Window> w2(CreateTestWindowInShellWithId(0));
 
   // Create a ShelfItem for w1.
   ShelfID id_w1 = CreateShelfItem(w1.get());
   EXPECT_EQ(2, model_->item_count());
 
   int index_w1 = model_->ItemIndexByID(id_w1);
   EXPECT_EQ(STATUS_RUNNING, model_->items()[index_w1].status);
 
   // Create a ShelfItem for w2.
   ShelfID id_w2 = CreateShelfItem(w2.get());
   EXPECT_EQ(3, model_->item_count());
 
   int index_w2 = model_->ItemIndexByID(id_w2);
   EXPECT_EQ(STATUS_RUNNING, model_->items()[index_w2].status);
 
-  // ShelfItem is removed when assoicated window is destroyed.
+  // ShelfItem is removed when its window property is cleared.
   ClearShelfItemDetailsForWindow(w1.get());
   EXPECT_EQ(2, model_->item_count());
   ClearShelfItemDetailsForWindow(w2.get());
   EXPECT_EQ(1, model_->item_count());
-  // Clears twice doesn't do anything.
+  // Clearing twice doesn't do anything.
   ClearShelfItemDetailsForWindow(w2.get());
   EXPECT_EQ(1, model_->item_count());
 }
 
 TEST_F(ShelfWindowWatcherTest, ActivateWindow) {
   // ShelfModel only have APP_LIST item.
   EXPECT_EQ(1, model_->item_count());
   std::unique_ptr<aura::Window> w1(CreateTestWindowInShellWithId(0));
   std::unique_ptr<aura::Window> w2(CreateTestWindowInShellWithId(0));
 
@@ skipping 72 matching lines @@
   // Restore window |window|.
   window_state->Restore();
   EXPECT_FALSE(window_state->IsMaximized());
   // No new item is created after restoring a window |window|.
   EXPECT_EQ(2, model_->item_count());
   // Index and id are not changed after maximizing a window |window|.
   EXPECT_EQ(index, model_->ItemIndexByID(id));
   EXPECT_EQ(id, model_->items()[index].id);
 }
 
-// Check that an item is removed when its associated Window is re-parented.
-TEST_F(ShelfWindowWatcherTest, ReparentWindow) {
+// Check that an item is maintained when its associated Window is docked.
+TEST_F(ShelfWindowWatcherTest, DockWindow) {
   // ShelfModel only has an APP_LIST item.
   EXPECT_EQ(1, model_->item_count());
 
   std::unique_ptr<aura::Window> window(CreateTestWindowInShellWithId(0));
   window->set_owned_by_parent(false);
 
   // Create a ShelfItem for |window|.
   ShelfID id = CreateShelfItem(window.get());
   EXPECT_EQ(2, model_->item_count());
 
   int index = model_->ItemIndexByID(id);
   EXPECT_EQ(STATUS_RUNNING, model_->items()[index].status);
 
   aura::Window* root_window = window->GetRootWindow();
   aura::Window* default_container =
       Shell::GetContainer(root_window, kShellWindowId_DefaultContainer);
   EXPECT_EQ(default_container, window->parent());
 
-  aura::Window* new_parent =
-      Shell::GetContainer(root_window, kShellWindowId_PanelContainer);
+  aura::Window* docked_container =
+      Shell::GetContainer(root_window, kShellWindowId_DockedContainer);
 
-  // Check |window|'s item is removed when it is re-parented to |new_parent|
-  // which is not default container.
-  new_parent->AddChild(window.get());
+  // Check |window|'s item is not removed when it is re-parented to the dock.
+  docked_container->AddChild(window.get());
+  EXPECT_EQ(2, model_->item_count());
+
+  // The shelf item is removed when the window is closed, even if it is in the
+  // docked container at the time.
+  window.reset();
   EXPECT_EQ(1, model_->item_count());
-
-  // Check |window|'s item is added when it is re-parented to
-  // |default_container|.
-  default_container->AddChild(window.get());
-  EXPECT_EQ(2, model_->item_count());
 }
 
 // Check |window|'s item is not changed during the dragging.
 // TODO(simonhong): Add a test for removing a Window during the dragging.
 TEST_F(ShelfWindowWatcherTest, DragWindow) {
   // ShelfModel only has an APP_LIST item.
   EXPECT_EQ(1, model_->item_count());
 
   std::unique_ptr<aura::Window> window(CreateTestWindowInShellWithId(0));
 
@@ skipping 10 matching lines @@
                           HTCAPTION, aura::client::WINDOW_MOVE_SOURCE_MOUSE));
   ASSERT_TRUE(resizer.get());
   resizer->Drag(gfx::Point(50, 50), 0);
   resizer->CompleteDrag();
 
   // Index and id are not changed after dragging a |window|.
   EXPECT_EQ(index, model_->ItemIndexByID(id));
   EXPECT_EQ(id, model_->items()[index].id);
 }
 
-// Check |window|'s item is removed when it is re-parented not to default
-// container during the dragging.
-TEST_F(ShelfWindowWatcherTest, ReparentWindowDuringTheDragging) {
-  // ShelfModel only has an APP_LIST item.
-  EXPECT_EQ(1, model_->item_count());
-
-  std::unique_ptr<aura::Window> window(CreateTestWindowInShellWithId(0));
-  window->set_owned_by_parent(false);
-
-  // Create a ShelfItem for |window|.
-  ShelfID id = CreateShelfItem(window.get());
-  EXPECT_EQ(2, model_->item_count());
-  int index = model_->ItemIndexByID(id);
-  EXPECT_EQ(STATUS_RUNNING, model_->items()[index].status);
-
-  aura::Window* root_window = window->GetRootWindow();
-  aura::Window* default_container =
-      Shell::GetContainer(root_window, kShellWindowId_DefaultContainer);
-  EXPECT_EQ(default_container, window->parent());
-
-  aura::Window* new_parent =
-      Shell::GetContainer(root_window, kShellWindowId_PanelContainer);
-
-  // Simulate re-parenting to |new_parent| during the dragging.
-  {
-    std::unique_ptr<WindowResizer> resizer(
-        CreateWindowResizer(WmWindowAura::Get(window.get()), gfx::Point(),
-                            HTCAPTION, aura::client::WINDOW_MOVE_SOURCE_MOUSE));
-    ASSERT_TRUE(resizer.get());
-    resizer->Drag(gfx::Point(50, 50), 0);
-    resizer->CompleteDrag();
-    EXPECT_EQ(2, model_->item_count());
-
-    // Item should be removed when |window| is re-parented not to default
-    // container before fininshing the dragging.
-    EXPECT_TRUE(wm::GetWindowState(window.get())->is_dragged());
-    new_parent->AddChild(window.get());
-    EXPECT_EQ(1, model_->item_count());
-  }
-  EXPECT_FALSE(wm::GetWindowState(window.get())->is_dragged());
-  EXPECT_EQ(1, model_->item_count());
-}
-
 }  // namespace ash