Timeout if website never completes the transaction.

third_party/WebKit/Source/modules/payments/PaymentRequest.h

Index: third_party/WebKit/Source/modules/payments/PaymentRequest.h
diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequest.h b/third_party/WebKit/Source/modules/payments/PaymentRequest.h
index 178f05d6c98b1ebbb583ed41b0c6aa72f3d1c609..2a59ff8c152da12f9a7785c2e5c6318641dab4d3 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentRequest.h
+++ b/third_party/WebKit/Source/modules/payments/PaymentRequest.h
@@ -17,6 +17,7 @@
 #include "modules/payments/PaymentOptions.h"
 #include "modules/payments/PaymentUpdater.h"
 #include "mojo/public/cpp/bindings/binding.h"
+#include "platform/Timer.h"
 #include "platform/heap/Handle.h"
 #include "public/platform/modules/payments/payment_request.mojom-blink.h"
 #include "wtf/Compiler.h"
@@ -72,6 +73,8 @@ public:
 
     DECLARE_TRACE();
 
+    void onTimerFired(TimerBase*);

[Marijn Kruisselbrink, 2016/08/01 22:42:25]

Especially if this is going to be a public method "onTimerFired" doesn't seem
like a very good name for it. Maybe something like onCompleteTimeout would be
better? Or at least something to indicate what this timer is.

Also if you don't like having this as a public method, a possibility would be to
make this method private and have a public onCompleteTimeoutForTesting method
that just calls the private method (we have presubmit checks that ensure
ForTesting methods are only called from tests).

[please use gerrit instead, 2016/08/01 23:55:35]

Done.

+
 private:
     PaymentRequest(ScriptState*, const HeapVector<PaymentMethodData>&, const PaymentDetails&, const PaymentOptions&, ExceptionState&);
 
@@ -102,6 +105,7 @@ private:
     Member<ScriptPromiseResolver> m_abortResolver;
     mojom::blink::PaymentRequestPtr m_paymentProvider;
     mojo::Binding<mojom::blink::PaymentRequestClient> m_clientBinding;
+    Timer<PaymentRequest> m_completeTimer;

[Marijn Kruisselbrink, 2016/08/01 22:42:25]

(in the future I believe using Timer directly for this is going to be
deprecated, and instead stuff will run on frame specific task runners (see
https://bugs.chromium.org/p/chromium/issues/detail?id=624694 for some info). But
I don't exactly know what is happening there, and it hasn't happened yet anyway,
so for now I believe this is still the correct usage of Timer).

[please use gerrit instead, 2016/08/01 23:55:35]

Acknowledged.

 };
 
 } // namespace blink