Timeout if website never completes the transaction.

third_party/WebKit/Source/modules/payments/PaymentRequest.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PaymentRequest_h
 #define PaymentRequest_h
 
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptValue.h"
 #include "bindings/core/v8/ScriptWrappable.h"
 #include "core/dom/ContextLifecycleObserver.h"
 #include "core/events/EventTarget.h"
 #include "modules/ModulesExport.h"
 #include "modules/payments/PaymentCompleter.h"
 #include "modules/payments/PaymentDetails.h"
 #include "modules/payments/PaymentMethodData.h"
 #include "modules/payments/PaymentOptions.h"
 #include "modules/payments/PaymentUpdater.h"
 #include "mojo/public/cpp/bindings/binding.h"
+#include "platform/Timer.h"
 #include "platform/heap/Handle.h"
 #include "public/platform/modules/payments/payment_request.mojom-blink.h"
 #include "wtf/Compiler.h"
 #include "wtf/Noncopyable.h"
 #include "wtf/RefPtr.h"
 #include "wtf/Vector.h"
 #include "wtf/text/WTFString.h"
 
 namespace blink {
 
@@ skipping 35 matching lines @@
 
     // PaymentCompleter:
     ScriptPromise complete(ScriptState*, PaymentComplete result) override;
 
     // PaymentUpdater:
     void onUpdatePaymentDetails(const ScriptValue& detailsScriptValue) override;
     void onUpdatePaymentDetailsFailure(const String& error) override;
 
     DECLARE_TRACE();
 
+    void onTimerFired(TimerBase*);

[Marijn Kruisselbrink, 2016/08/01 22:42:25]

Especially if this is going to be a public method "onTimerFired" doesn't seem
like a very good name for it. Maybe something like onCompleteTimeout would be
better? Or at least something to indicate what this timer is.

Also if you don't like having this as a public method, a possibility would be to
make this method private and have a public onCompleteTimeoutForTesting method
that just calls the private method (we have presubmit checks that ensure
ForTesting methods are only called from tests).

[please use gerrit instead, 2016/08/01 23:55:35]

Done.

+
 private:
     PaymentRequest(ScriptState*, const HeapVector<PaymentMethodData>&, const PaymentDetails&, const PaymentOptions&, ExceptionState&);
 
     // LifecycleObserver:
     void contextDestroyed() override;
 
     // ActiveScriptWrappable:
     bool hasPendingActivity() const override;
 
     // mojom::blink::PaymentRequestClient:
@@ skipping 10 matching lines @@
     Vector<MethodData> m_methodData;
     PaymentDetails m_details;
     PaymentOptions m_options;
     Member<PaymentAddress> m_shippingAddress;
     String m_shippingOption;
     Member<ScriptPromiseResolver> m_showResolver;
     Member<ScriptPromiseResolver> m_completeResolver;
     Member<ScriptPromiseResolver> m_abortResolver;
     mojom::blink::PaymentRequestPtr m_paymentProvider;
     mojo::Binding<mojom::blink::PaymentRequestClient> m_clientBinding;
+    Timer<PaymentRequest> m_completeTimer;

[Marijn Kruisselbrink, 2016/08/01 22:42:25]

(in the future I believe using Timer directly for this is going to be
deprecated, and instead stuff will run on frame specific task runners (see
https://bugs.chromium.org/p/chromium/issues/detail?id=624694 for some info). But
I don't exactly know what is happening there, and it hasn't happened yet anyway,
so for now I believe this is still the correct usage of Timer).

[please use gerrit instead, 2016/08/01 23:55:35]

Acknowledged.

 };
 
 } // namespace blink
 
 #endif // PaymentRequest_h