Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2192333002: [DevTools] Remove & add required methods (Closed)

Created:
4 years, 4 months ago by eostroukhov-old
Modified:
4 years, 4 months ago
Reviewers:
dgozman, pfeldman, vinodsonkusare77
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove & add required methods R=dgozman, pfeldman BUG= Committed: https://crrev.com/868cfa16fa88e5b757dfc360724f3c2430350c52 Cr-Commit-Position: refs/heads/master@{#408838}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
eostroukhov-old
4 years, 4 months ago (2016-07-30 00:48:33 UTC) #3
dgozman
lgtm
4 years, 4 months ago (2016-07-30 00:49:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192333002/1
4 years, 4 months ago (2016-07-30 00:49:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-30 01:53:42 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/868cfa16fa88e5b757dfc360724f3c2430350c52 Cr-Commit-Position: refs/heads/master@{#408838}
4 years, 4 months ago (2016-07-30 01:55:06 UTC) #10
vinodsonkusare77_gmail.com
https://youtu.be/lo2wQj73Mvo?list=UUWQUZfAdokV83KKjLl-sDeQ On Sat, Jul 30, 2016 at 7:25 AM, commit-bot@chromium.org via codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote: > ...
4 years, 4 months ago (2016-08-17 10:17:18 UTC) #11
vinodsonkusare77_gmail.com
4 years, 4 months ago (2016-08-17 10:17:19 UTC) #12
Message was sent while issue was closed.
https://youtu.be/lo2wQj73Mvo?list=UUWQUZfAdokV83KKjLl-sDeQ

On Sat, Jul 30, 2016 at 7:25 AM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Patchset 1 (id:??) landed as
> https://crrev.com/868cfa16fa88e5b757dfc360724f3c2430350c52
> Cr-Commit-Position: refs/heads/master@{#408838}
>
> https://codereview.chromium.org/2192333002/
>
> --
> You received this message because you are subscribed to the Google Groups
> "DevTools Reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to devtools-reviews+unsubscribe@chromium.org.
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698